Decomposer valid frequency logic - #3811
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3811 +/- ##
=======================================
+ Coverage 99.7% 99.7% +0.1%
=======================================
Files 344 344
Lines 36116 36123 +7
=======================================
+ Hits 35979 35986 +7
Misses 137 137
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
eccabay
marked this pull request as ready for review
November 2, 2022 18:17
eccabay
requested review from
christopherbunn,
chukarsten and
jeremyliweishih
November 2, 2022 18:17
jeremyliweishih
approved these changes
Nov 2, 2022
fjlanasa
reviewed
Nov 14, 2022
christopherbunn
approved these changes
Nov 14, 2022
christopherbunn
left a comment
Contributor
There was a problem hiding this comment.
LGTM once edge case mentioned in Frank's comment is addressed.
fjlanasa
approved these changes
Nov 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidates all the logic for whether a frequency will work with a given decomposer to the decomposer classes themselves.