Skip to content

Decomposer valid frequency logic - #3811

Merged
eccabay merged 7 commits into
mainfrom
decomp_freq_cleanup
Nov 15, 2022
Merged

Decomposer valid frequency logic#3811
eccabay merged 7 commits into
mainfrom
decomp_freq_cleanup

Conversation

@eccabay

@eccabay eccabay commented Nov 2, 2022

Copy link
Copy Markdown
Contributor

Consolidates all the logic for whether a frequency will work with a given decomposer to the decomposer classes themselves.

@codecov

codecov Bot commented Nov 2, 2022

Copy link
Copy Markdown

Codecov Report

Merging #3811 (9449e2d) into main (46a6564) will increase coverage by 0.1%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main   #3811     +/-   ##
=======================================
+ Coverage   99.7%   99.7%   +0.1%     
=======================================
  Files        344     344             
  Lines      36116   36123      +7     
=======================================
+ Hits       35979   35986      +7     
  Misses       137     137             
Impacted Files Coverage Δ
evalml/tests/pipeline_tests/test_pipeline_utils.py 99.8% <ø> (ø)
...omponents/transformers/preprocessing/decomposer.py 99.3% <100.0%> (+0.1%) ⬆️
...nents/transformers/preprocessing/stl_decomposer.py 100.0% <100.0%> (ø)
evalml/pipelines/utils.py 99.6% <100.0%> (-<0.1%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@eccabay
eccabay marked this pull request as ready for review November 2, 2022 18:17

@jeremyliweishih jeremyliweishih left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice

Comment thread evalml/pipelines/components/transformers/preprocessing/decomposer.py Outdated

@christopherbunn christopherbunn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once edge case mentioned in Frank's comment is addressed.

@eccabay
eccabay enabled auto-merge (squash) November 15, 2022 14:28
@eccabay
eccabay merged commit 8cf0cda into main Nov 15, 2022
@eccabay
eccabay deleted the decomp_freq_cleanup branch November 15, 2022 14:52
@chukarsten chukarsten mentioned this pull request Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants