Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Int64Index after Pandas 1.5 Upgrade #3825

Merged
merged 5 commits into from
Dec 6, 2022

Conversation

christopherbunn
Copy link
Contributor

@christopherbunn christopherbunn commented Nov 7, 2022

Blocked on #3759
Resolves #3760

@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Merging #3825 (4066e31) into main (53a4912) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main   #3825     +/-   ##
=======================================
- Coverage   99.7%   99.7%   -0.0%     
=======================================
  Files        344     344             
  Lines      36211   36209      -2     
=======================================
- Hits       36074   36072      -2     
  Misses       137     137             
Impacted Files Coverage Δ
...omponents/transformers/preprocessing/decomposer.py 99.3% <100.0%> (-<0.1%) ⬇️
...ransformers/preprocessing/polynomial_decomposer.py 100.0% <100.0%> (ø)
...nents/transformers/preprocessing/stl_decomposer.py 100.0% <100.0%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@christopherbunn christopherbunn marked this pull request as ready for review December 5, 2022 22:19
@christopherbunn christopherbunn requested review from eccabay, chukarsten, jeremyliweishih and fjlanasa and removed request for eccabay December 5, 2022 22:19
Copy link
Collaborator

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - we should be good with existing coverage

@christopherbunn christopherbunn merged commit 79a6db1 into main Dec 6, 2022
@christopherbunn christopherbunn deleted the OSSEVALML-406_rm_int64index branch December 6, 2022 21:00
@christopherbunn christopherbunn mentioned this pull request Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor STLDecomposer/Decomposer to not use Int64Index
3 participants