Conversation
Codecov Report
@@ Coverage Diff @@
## main #3835 +/- ##
=======================================
+ Coverage 99.7% 99.7% +0.1%
=======================================
Files 344 344
Lines 36123 36124 +1
=======================================
+ Hits 35986 35987 +1
Misses 137 137
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
eccabay
requested review from
christopherbunn,
chukarsten,
fjlanasa and
jeremyliweishih
jeremyliweishih
approved these changes
Nov 15, 2022
Collaborator
jeremyliweishih
left a comment
jeremyliweishih
left a comment
There was a problem hiding this comment.
LGTM - just one thing of note
| "axs[3].plot(res[0][\"residual\"], \"y\")\n", | ||
| "axs[3].set_title(\"residual\")\n", | ||
| "plt.show()" | ||
| "res = pdc.plot_decomposition(X_train_time, y_train_time)" |
Collaborator
There was a problem hiding this comment.
the image isn't showing here for some reason - can you double check?
Contributor
Author
There was a problem hiding this comment.
I'm seeing it with no problem - are you sure it's missing?
Collaborator
There was a problem hiding this comment.
I can see it now - might have just been my browser!
chukarsten
approved these changes
Nov 16, 2022
Contributor
chukarsten
left a comment
chukarsten
left a comment
There was a problem hiding this comment.
Thanks for doing this!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a section about STL decomposition to the docs.
Also, removed the
Could not find requested time_index Nonewarning that was popping up unnecessarily, because it was annoying.