Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add STL to Time Series Documentation #3835

Merged
merged 9 commits into from
Nov 16, 2022
Merged

Add STL to Time Series Documentation #3835

merged 9 commits into from
Nov 16, 2022

Conversation

eccabay
Copy link
Contributor

@eccabay eccabay commented Nov 15, 2022

Adds a section about STL decomposition to the docs.

Also, removed the Could not find requested time_index None warning that was popping up unnecessarily, because it was annoying.

@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Merging #3835 (0041557) into main (1742fed) will increase coverage by 0.1%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main   #3835     +/-   ##
=======================================
+ Coverage   99.7%   99.7%   +0.1%     
=======================================
  Files        344     344             
  Lines      36123   36124      +1     
=======================================
+ Hits       35986   35987      +1     
  Misses       137     137             
Impacted Files Coverage Δ
evalml/utils/gen_utils.py 99.3% <100.0%> (+0.1%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@eccabay eccabay marked this pull request as ready for review November 15, 2022 17:02
Copy link
Collaborator

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just one thing of note

"axs[3].plot(res[0][\"residual\"], \"y\")\n",
"axs[3].set_title(\"residual\")\n",
"plt.show()"
"res = pdc.plot_decomposition(X_train_time, y_train_time)"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the image isn't showing here for some reason - can you double check?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing it with no problem - are you sure it's missing?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see it now - might have just been my browser!

Copy link
Contributor

@chukarsten chukarsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@eccabay eccabay enabled auto-merge (squash) November 16, 2022 16:18
@eccabay eccabay merged commit 9def394 into main Nov 16, 2022
@eccabay eccabay deleted the 5491_decomp_docs branch November 16, 2022 16:38
@chukarsten chukarsten mentioned this pull request Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants