-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add STL to Time Series Documentation #3835
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3835 +/- ##
=======================================
+ Coverage 99.7% 99.7% +0.1%
=======================================
Files 344 344
Lines 36123 36124 +1
=======================================
+ Hits 35986 35987 +1
Misses 137 137
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - just one thing of note
"axs[3].plot(res[0][\"residual\"], \"y\")\n", | ||
"axs[3].set_title(\"residual\")\n", | ||
"plt.show()" | ||
"res = pdc.plot_decomposition(X_train_time, y_train_time)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the image isn't showing here for some reason - can you double check?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm seeing it with no problem - are you sure it's missing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see it now - might have just been my browser!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this!
Adds a section about STL decomposition to the docs.
Also, removed the
Could not find requested time_index None
warning that was popping up unnecessarily, because it was annoying.