Add DFSTransformer to time series pipelines#3836
Merged
jeremyliweishih merged 11 commits intomainfrom Nov 18, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3836 +/- ##
=======================================
+ Coverage 99.7% 99.7% +0.1%
=======================================
Files 344 344
Lines 36175 36185 +10
=======================================
+ Hits 36038 36048 +10
Misses 137 137
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jeremyliweishih
commented
Nov 15, 2022
| + delayed_features | ||
| + natural_language_featurizer | ||
| + datetime | ||
| + natural_language_featurizer |
Collaborator
Author
There was a problem hiding this comment.
I'm not sure how this was passing before. For non-TS problems the NaturalLanguageFeaturizer should always go after the DatetimeFeaturizer
jeremyliweishih
requested review from
christopherbunn,
chukarsten,
eccabay,
fjlanasa,
ozzieD and
thehomebrewnerd
ozzieD
approved these changes
Nov 17, 2022
thehomebrewnerd
approved these changes
Nov 17, 2022
Contributor
thehomebrewnerd
left a comment
thehomebrewnerd
left a comment
There was a problem hiding this comment.
Just one non-blocking comment, but otherwise looks good.
| Valid options are "DatetimeFeaturizer", "EmailFeaturizer", "URLFeaturizer", "NaturalLanguageFeaturizer", "TimeSeriesFeaturizer" | ||
| include_decomposer (bool): For time series regression problems, whether or not to include a decomposer in the generated pipeline. | ||
| Defaults to True. | ||
| features (bool): Whether to add a DFSTransformer component to this pipeline. |
Contributor
There was a problem hiding this comment.
Just wondering if this param should be called something like add_dfs_transformer instead of features to make it a bit more clear? I guess this is consistent with what is used in make_pipeline though.
eccabay
approved these changes
Nov 18, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3931