-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DFSTransformer to time series pipelines #3836
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3836 +/- ##
=======================================
+ Coverage 99.7% 99.7% +0.1%
=======================================
Files 344 344
Lines 36175 36185 +10
=======================================
+ Hits 36038 36048 +10
Misses 137 137
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
+ datetime | ||
+ natural_language_featurizer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how this was passing before. For non-TS problems the NaturalLanguageFeaturizer
should always go after the DatetimeFeaturizer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one non-blocking comment, but otherwise looks good.
@@ -385,6 +386,7 @@ def _make_pipeline_time_series( | |||
Valid options are "DatetimeFeaturizer", "EmailFeaturizer", "URLFeaturizer", "NaturalLanguageFeaturizer", "TimeSeriesFeaturizer" | |||
include_decomposer (bool): For time series regression problems, whether or not to include a decomposer in the generated pipeline. | |||
Defaults to True. | |||
features (bool): Whether to add a DFSTransformer component to this pipeline. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wondering if this param should be called something like add_dfs_transformer
instead of features
to make it a bit more clear? I guess this is consistent with what is used in make_pipeline
though.
Fixes #3931