Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DFSTransformer to time series pipelines #3836

Merged
merged 11 commits into from
Nov 18, 2022
Merged

Conversation

jeremyliweishih
Copy link
Collaborator

@jeremyliweishih jeremyliweishih commented Nov 15, 2022

Fixes #3931

@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Merging #3836 (9554168) into main (459ba58) will increase coverage by 0.1%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main   #3836     +/-   ##
=======================================
+ Coverage   99.7%   99.7%   +0.1%     
=======================================
  Files        344     344             
  Lines      36175   36185     +10     
=======================================
+ Hits       36038   36048     +10     
  Misses       137     137             
Impacted Files Coverage Δ
evalml/pipelines/utils.py 99.6% <100.0%> (+0.1%) ⬆️
...valml/tests/automl_tests/test_default_algorithm.py 100.0% <100.0%> (ø)
evalml/tests/pipeline_tests/test_pipeline_utils.py 99.8% <100.0%> (+0.1%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

+ datetime
+ natural_language_featurizer
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how this was passing before. For non-TS problems the NaturalLanguageFeaturizer should always go after the DatetimeFeaturizer

Copy link
Contributor

@thehomebrewnerd thehomebrewnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one non-blocking comment, but otherwise looks good.

@@ -385,6 +386,7 @@ def _make_pipeline_time_series(
Valid options are "DatetimeFeaturizer", "EmailFeaturizer", "URLFeaturizer", "NaturalLanguageFeaturizer", "TimeSeriesFeaturizer"
include_decomposer (bool): For time series regression problems, whether or not to include a decomposer in the generated pipeline.
Defaults to True.
features (bool): Whether to add a DFSTransformer component to this pipeline.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering if this param should be called something like add_dfs_transformer instead of features to make it a bit more clear? I guess this is consistent with what is used in make_pipeline though.

@jeremyliweishih jeremyliweishih enabled auto-merge (squash) November 18, 2022 16:19
@jeremyliweishih jeremyliweishih merged commit 5b0508b into main Nov 18, 2022
@jeremyliweishih jeremyliweishih deleted the js_3931_dfs_ts branch November 18, 2022 16:52
@chukarsten chukarsten mentioned this pull request Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants