Reduce use_covariates threshold - #3868
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3868 +/- ##
=======================================
+ Coverage 99.7% 99.7% +0.1%
=======================================
Files 344 344
Lines 36185 36191 +6
=======================================
+ Hits 36048 36054 +6
Misses 137 137
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jeremyliweishih
left a comment
There was a problem hiding this comment.
LGTM just a suggestion
christopherbunn
left a comment
There was a problem hiding this comment.
LGTM, just a question
| """[ProblemTypes.TIME_SERIES_REGRESSION]""" | ||
|
|
||
| max_rows = 1000 | ||
| max_cols = 7 |
There was a problem hiding this comment.
Not a blocker but is there a reason why this is 7 and not like 5 or 10? Just very curious haha
There was a problem hiding this comment.
Nope, no strong motivation behind it. It was just a bit of a bump down, and without a more comprehensive set of datasets there was no way to test where the best line in the sand would be. Since these results seemed ok, I just stuck with it.
Moves to defaulting to
use_covariates=Falsein more cases, since it produces significant slowdown without much benefit for larger datasets