Reduce use_covariates threshold #3868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3868 +/- ##
=======================================
+ Coverage 99.7% 99.7% +0.1%
=======================================
Files 344 344
Lines 36185 36191 +6
=======================================
+ Hits 36048 36054 +6
Misses 137 137
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
eccabay
requested review from
jeremyliweishih,
chukarsten,
christopherbunn and
fjlanasa
jeremyliweishih
approved these changes
Nov 30, 2022
christopherbunn
approved these changes
Dec 1, 2022
| @@ -61,6 +61,9 @@ class ARIMARegressor(Estimator): | |||
| supported_problem_types = [ProblemTypes.TIME_SERIES_REGRESSION] | |||
| """[ProblemTypes.TIME_SERIES_REGRESSION]""" | |||
|
|
|||
| max_rows = 1000 | |||
| max_cols = 7 | |||
There was a problem hiding this comment.
Not a blocker but is there a reason why this is 7 and not like 5 or 10? Just very curious haha
There was a problem hiding this comment.
Nope, no strong motivation behind it. It was just a bit of a bump down, and without a more comprehensive set of datasets there was no way to test where the best line in the sand would be. Since these results seemed ok, I just stuck with it.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves to defaulting to
use_covariates=Falsein more cases, since it produces significant slowdown without much benefit for larger datasets