Skip to content

Reduce use_covariates threshold - #3868

Merged
eccabay merged 3 commits into
mainfrom
450_use_covariates_threshold
Dec 1, 2022
Merged

eccabay merged 3 commits into
mainfrom
450_use_covariates_threshold

Conversation

@eccabay

@eccabay eccabay commented Nov 30, 2022

Copy link
Copy Markdown
Contributor

Moves to defaulting to use_covariates=False in more cases, since it produces significant slowdown without much benefit for larger datasets

@codecov

codecov Bot commented Nov 30, 2022

Copy link
Copy Markdown

Codecov Report

Merging #3868 (332e3ba) into main (7438c15) will increase coverage by 0.1%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main   #3868     +/-   ##
=======================================
+ Coverage   99.7%   99.7%   +0.1%     
=======================================
  Files        344     344             
  Lines      36185   36191      +6     
=======================================
+ Hits       36048   36054      +6     
  Misses       137     137             
Impacted Files Coverage Δ
evalml/automl/automl_search.py 99.5% <ø> (ø)
...omponents/estimators/regressors/arima_regressor.py 100.0% <100.0%> (ø)
evalml/tests/automl_tests/test_automl.py 99.5% <100.0%> (+0.1%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@eccabay
eccabay marked this pull request as ready for review November 30, 2022 20:33

@jeremyliweishih jeremyliweishih left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just a suggestion

Comment thread evalml/automl/automl_search.py Outdated

@christopherbunn christopherbunn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a question

"""[ProblemTypes.TIME_SERIES_REGRESSION]"""

max_rows = 1000
max_cols = 7

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker but is there a reason why this is 7 and not like 5 or 10? Just very curious haha

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, no strong motivation behind it. It was just a bit of a bump down, and without a more comprehensive set of datasets there was no way to test where the best line in the sand would be. Since these results seemed ok, I just stuck with it.

@eccabay
eccabay merged commit e18dd14 into main Dec 1, 2022
@eccabay
eccabay deleted the 450_use_covariates_threshold branch December 1, 2022 19:01
@christopherbunn christopherbunn mentioned this pull request Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants