Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dsherry from automated dependency checker reviews #3870

Merged
merged 7 commits into from
Dec 12, 2022

Conversation

dsherry
Copy link
Contributor

@dsherry dsherry commented Dec 1, 2022

I'm taking a moment to clean up my github review notifications in slack--I haven't been reviewing automated dependency updates and the team has been taking care of that without my help for months 😆

@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Merging #3870 (2f2a90e) into main (a7384e7) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main   #3870   +/-   ##
=====================================
  Coverage   99.7%   99.7%           
=====================================
  Files        346     346           
  Lines      36284   36284           
=====================================
  Hits       36147   36147           
  Misses       137     137           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dsherry dsherry marked this pull request as draft December 2, 2022 15:25
@dsherry dsherry force-pushed the ds_dep_checker_update branch from 082ff54 to 46e1a6d Compare December 6, 2022 15:30
@dsherry dsherry marked this pull request as ready for review December 7, 2022 14:29
Copy link
Contributor

@eccabay eccabay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥲 do you want to remove yourself from the conda recipe maintainers (in .github/meta.yaml) as well?

@eccabay
Copy link
Contributor

eccabay commented Dec 7, 2022

@dsherry I hope you don't mind, I borrowed your PR to add @tamargrey at the same time!

@dsherry
Copy link
Contributor Author

dsherry commented Dec 7, 2022

thanks!

🥲 do you want to remove yourself from the conda recipe maintainers (in .github/meta.yaml) as well?

Nah that’s ok I’ll stay on there :)

@dsherry dsherry merged commit 24a01ae into main Dec 12, 2022
@dsherry dsherry deleted the ds_dep_checker_update branch December 12, 2022 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants