Hid non-essential warning messages in time series docs#3890
Merged
christopherbunn merged 3 commits intomainfrom Dec 15, 2022
Merged
Hid non-essential warning messages in time series docs#3890christopherbunn merged 3 commits intomainfrom
christopherbunn merged 3 commits intomainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3890 +/- ##
=====================================
Coverage 99.7% 99.7%
=====================================
Files 346 346
Lines 36358 36358
=====================================
Hits 36227 36227
Misses 131 131 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
christopherbunn
requested review from
chukarsten,
eccabay,
fjlanasa and
jeremyliweishih
and removed request for
eccabay
eccabay
approved these changes
Dec 14, 2022
Contributor
eccabay
left a comment
eccabay
left a comment
There was a problem hiding this comment.
Looks good!
Should we file a follow up issue to track removing those parameter not used warnings? It seems like those shouldn't be raised in the first place.
Unrelated to this issue, I'm concerned by the fact that we're getting info-level logging information. We shouldn't be, since verbose is set to false. I think one of our dependencies may be mucking with the logging configuration, which is something for us to keep an eye on.
| * Changes | ||
| * Added a threshold to ``DateTimeFormatDataCheck`` to account for too many duplicate or nan values :pr:`3883` | ||
| * Documentation Changes | ||
| * Hide non-essential warning messages in time series docs :pr:`3890` |
christopherbunn
force-pushed
the
3620_hide_timeseries_doc_warnings
branch
from
5c8f037 to
f428d1d
Compare
christopherbunn
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3620
A lot of the warning messages that we are seeing has to do with a lot of the internal solvers being unable to find convergence. A significant amount of these errors can be filtered out by filtering them in a hidden cell.
In addition, for the known in advance section, a number of errors are
UserErrorsrelated to initial parameter inits in addition to the above convergence error messages. This second cell hiding UserErrors I am a bit more skeptical about as it's a bit broad and leaves room for actual errors to be hidden in the future.Current page: https://evalml.alteryx.com/en/stable/user_guide/timeseries.html#Known-in-advance-features
Updated page: https://feature-labs-inc-evalml--3890.com.readthedocs.build/en/3890/user_guide/timeseries.html#Known-in-advance-features