Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cast OneHotEncoder created columns to bool #3913

Merged
merged 2 commits into from
Jan 10, 2023
Merged

Conversation

ParthivNaresh
Copy link
Contributor

@ParthivNaresh ParthivNaresh commented Jan 9, 2023

Casting OHE created columns to bool dtype before initializing through woodwork will help save time during transformation

@codecov
Copy link

codecov bot commented Jan 9, 2023

Codecov Report

Merging #3913 (2179089) into main (e1155fa) will increase coverage by 0.1%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main   #3913     +/-   ##
=======================================
+ Coverage   99.7%   99.7%   +0.1%     
=======================================
  Files        346     346             
  Lines      36665   36667      +2     
=======================================
+ Hits       36532   36534      +2     
  Misses       133     133             
Impacted Files Coverage Δ
...components/transformers/encoders/onehot_encoder.py 100.0% <100.0%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ParthivNaresh ParthivNaresh marked this pull request as ready for review January 10, 2023 19:20
@ParthivNaresh
Copy link
Contributor Author

ParthivNaresh commented Jan 10, 2023

@jeremyliweishih @fjlanasa Not sure the best way to test this since it's just a dtype change that ends up getting transformed by woodwork anyways

@jeremyliweishih
Copy link
Collaborator

@ParthivNaresh LGTM

@ParthivNaresh ParthivNaresh merged commit 5e5d652 into main Jan 10, 2023
@ParthivNaresh ParthivNaresh deleted the cast_bool_in_ohe branch January 10, 2023 21:15
@christopherbunn christopherbunn mentioned this pull request Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants