-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove non-selected-categorical columns from dataframe used to create numeric pipelines in DefaultAlgo #3914
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3914 +/- ##
========================================
+ Coverage 84.1% 99.7% +15.6%
========================================
Files 346 346
Lines 36667 36669 +2
========================================
+ Hits 30816 36536 +5720
+ Misses 5851 133 -5718
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
If a dataframe contained a categorical column that was not selected by the feature selector,
DefaultAlgorithm
would send a dataframe with such categorical column to the make pipeline util for the numeric pipeline. This would cause a OHE to be inserted into the numeric pipeline. This change makes it so that a dataframe matching the parameters in theSelectByType
is sent to the pipeline util instead.