Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non-selected-categorical columns from dataframe used to create numeric pipelines in DefaultAlgo #3914

Merged
merged 7 commits into from
Jan 11, 2023

Conversation

jeremyliweishih
Copy link
Collaborator

@jeremyliweishih jeremyliweishih commented Jan 10, 2023

If a dataframe contained a categorical column that was not selected by the feature selector, DefaultAlgorithm would send a dataframe with such categorical column to the make pipeline util for the numeric pipeline. This would cause a OHE to be inserted into the numeric pipeline. This change makes it so that a dataframe matching the parameters in the SelectByType is sent to the pipeline util instead.

@jeremyliweishih jeremyliweishih marked this pull request as ready for review January 10, 2023 18:09
@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Merging #3914 (827f0bc) into main (5e5d652) will increase coverage by 15.6%.
The diff coverage is 100.0%.

@@           Coverage Diff            @@
##            main   #3914      +/-   ##
========================================
+ Coverage   84.1%   99.7%   +15.6%     
========================================
  Files        346     346              
  Lines      36667   36669       +2     
========================================
+ Hits       30816   36536    +5720     
+ Misses      5851     133    -5718     
Impacted Files Coverage Δ
...valml/automl/automl_algorithm/default_algorithm.py 100.0% <100.0%> (+37.4%) ⬆️
...valml/tests/automl_tests/test_default_algorithm.py 100.0% <100.0%> (+100.0%) ⬆️
evalml/pipelines/utils.py 99.6% <0.0%> (+2.0%) ⬆️
evalml/tests/conftest.py 98.0% <0.0%> (+4.5%) ⬆️
evalml/automl/engine/engine_base.py 100.0% <0.0%> (+5.6%) ⬆️
.../preprocessing/data_splitters/time_series_split.py 96.7% <0.0%> (+13.4%) ⬆️
evalml/automl/automl_algorithm/automl_algorithm.py 100.0% <0.0%> (+16.5%) ⬆️
evalml/automl/utils.py 97.3% <0.0%> (+16.5%) ⬆️
evalml/tuners/tuner.py 100.0% <0.0%> (+24.6%) ⬆️
evalml/automl/automl_search.py 99.6% <0.0%> (+31.0%) ⬆️
... and 26 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@eccabay eccabay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@ParthivNaresh ParthivNaresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jeremyliweishih jeremyliweishih merged commit 821d2a6 into main Jan 11, 2023
@jeremyliweishih jeremyliweishih deleted the js_fix_default_algo_OHE branch January 11, 2023 05:11
@christopherbunn christopherbunn mentioned this pull request Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants