Remove non-selected-categorical columns from dataframe used to create numeric pipelines in DefaultAlgo#3914
Merged
jeremyliweishih merged 7 commits intomainfrom Jan 11, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3914 +/- ##
========================================
+ Coverage 84.1% 99.7% +15.6%
========================================
Files 346 346
Lines 36667 36669 +2
========================================
+ Hits 30816 36536 +5720
+ Misses 5851 133 -5718
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a dataframe contained a categorical column that was not selected by the feature selector,
DefaultAlgorithmwould send a dataframe with such categorical column to the make pipeline util for the numeric pipeline. This would cause a OHE to be inserted into the numeric pipeline. This change makes it so that a dataframe matching the parameters in theSelectByTypeis sent to the pipeline util instead.