Skip to content

Add ruff and use pyproject.toml (move away from setup.cfg) - #3928

Merged
gsheni merged 25 commits into
mainfrom
add_ruff
Jan 19, 2023
Merged

Add ruff and use pyproject.toml (move away from setup.cfg)#3928
gsheni merged 25 commits into
mainfrom
add_ruff

Conversation

@gsheni

@gsheni gsheni commented Jan 12, 2023

Copy link
Copy Markdown
Contributor

Fixes #3684

@gsheni gsheni self-assigned this Jan 12, 2023
@codecov

codecov Bot commented Jan 12, 2023

Copy link
Copy Markdown

Codecov Report

Merging #3928 (e2b21b9) into main (b40b423) will increase coverage by 0.1%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main   #3928     +/-   ##
=======================================
+ Coverage   99.7%   99.7%   +0.1%     
=======================================
  Files        346     346             
  Lines      36727   36719      -8     
=======================================
- Hits       36594   36589      -5     
+ Misses       133     130      -3     
Impacted Files Coverage Δ
evalml/automl/automl_search.py 99.6% <ø> (ø)
evalml/data_checks/datetime_format_data_check.py 100.0% <ø> (ø)
evalml/data_checks/id_columns_data_check.py 100.0% <ø> (ø)
...tanding/prediction_explanations/_user_interface.py 100.0% <ø> (ø)
evalml/model_understanding/visualizations.py 100.0% <ø> (ø)
evalml/objectives/objective_base.py 100.0% <ø> (ø)
.../pipelines/binary_classification_pipeline_mixin.py 100.0% <ø> (ø)
evalml/pipelines/components/component_base.py 100.0% <ø> (ø)
evalml/pipelines/utils.py 99.6% <ø> (ø)
evalml/tests/automl_tests/dask_test_utils.py 100.0% <ø> (ø)
... and 49 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gsheni
gsheni requested a review from a team January 13, 2023 13:51
Comment thread evalml/utils/cli_utils.py Outdated
@gsheni
gsheni enabled auto-merge (squash) January 13, 2023 18:12
@gsheni
gsheni requested a review from cp2boston January 13, 2023 18:29

@cp2boston cp2boston left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@eccabay eccabay left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just want to make sure we're not excluding too much from our code coverage

Comment thread Makefile Outdated
Comment thread pyproject.toml
Comment thread evalml/tests/model_understanding_tests/test_partial_dependence.py Outdated
@gsheni
gsheni merged commit 43c7ad4 into main Jan 19, 2023
@chukarsten chukarsten mentioned this pull request Jan 25, 2023
@gsheni
gsheni deleted the add_ruff branch January 25, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Transition EvalML to use pyproject.toml only (move away from setup.cfg)

3 participants