Skip to content

Remove second identical batch for time series in DefaultAlgorithm - #3936

Merged
chukarsten merged 14 commits into
mainfrom
js_fix_time_series_default_batches
Jan 24, 2023
Merged

chukarsten merged 14 commits into
mainfrom
js_fix_time_series_default_batches

Conversation

@jeremyliweishih

Copy link
Copy Markdown
Collaborator

Since we're not running feature selection for time series in DefaultAlgorithm we were running a second identical batch. This removes it.

@codecov

codecov Bot commented Jan 18, 2023 •

Copy link
Copy Markdown

Codecov Report

Merging #3936 (42da206) into main (fce64ad) will increase coverage by 29.7%.
The diff coverage is 100.0%.

@@           Coverage Diff            @@
##            main   #3936      +/-   ##
========================================
+ Coverage   70.1%   99.7%   +29.7%     
========================================
  Files        347     347              
  Lines      36745   36744       -1     
========================================
+ Hits       25744   36623   +10879     
+ Misses     11001     121   -10880     
Impacted Files Coverage Δ
...ts/automl_tests/parallel_tests/test_automl_dask.py 96.1% <ø> (ø)
...valml/automl/automl_algorithm/default_algorithm.py 100.0% <100.0%> (ø)
evalml/tests/automl_tests/test_automl.py 99.6% <100.0%> (+0.1%) ⬆️
...valml/tests/automl_tests/test_default_algorithm.py 100.0% <100.0%> (ø)
...elines/components/transformers/column_selectors.py 92.9% <0.0%> (+1.5%) ⬆️
evalml/utils/gen_utils.py 99.3% <0.0%> (+1.5%) ⬆️
...ponents/transformers/preprocessing/featuretools.py 100.0% <0.0%> (+1.5%) ⬆️
evalml/objectives/standard_metrics.py 100.0% <0.0%> (+1.7%) ⬆️
...es/components/transformers/samplers/oversampler.py 100.0% <0.0%> (+1.8%) ⬆️
...onents/estimators/regressors/catboost_regressor.py 100.0% <0.0%> (+2.7%) ⬆️
... and 172 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jeremyliweishih
jeremyliweishih marked this pull request as ready for review January 18, 2023 21:28
@jeremyliweishih
jeremyliweishih requested review from christopherbunn, chukarsten, eccabay and fjlanasa and removed request for chukarsten and eccabay January 19, 2023 18:48
@jeremyliweishih
jeremyliweishih enabled auto-merge (squash) January 24, 2023 15:44
@chukarsten
chukarsten disabled auto-merge January 24, 2023 16:57
@chukarsten
chukarsten merged commit 85c98fb into main Jan 24, 2023
@chukarsten
chukarsten deleted the js_fix_time_series_default_batches branch January 24, 2023 16:57
@chukarsten chukarsten mentioned this pull request Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants