Add dates_needed_for_prediction_range#3941
Merged
jeremyliweishih merged 19 commits intomainfrom Jan 26, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3941 +/- ##
=======================================
+ Coverage 99.7% 99.7% +0.1%
=======================================
Files 347 347
Lines 36744 36768 +24
=======================================
+ Hits 36623 36647 +24
Misses 121 121
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jeremyliweishih
requested review from
christopherbunn,
chukarsten,
eccabay and
fjlanasa
and removed request for
christopherbunn and
eccabay
chukarsten
approved these changes
Jan 24, 2023
Contributor
chukarsten
left a comment
chukarsten
left a comment
There was a problem hiding this comment.
I think just need to update the docstring!
eccabay
suggested changes
Jan 24, 2023
Contributor
eccabay
left a comment
eccabay
left a comment
There was a problem hiding this comment.
The code looks great! I think the addition to the docs needs a bit of clarification, it's hard to understand exactly what the goal is with it.
…_for_prediction_range
…eryx/evalml into js_dates_needed_for_prediction_range
eccabay
approved these changes
Jan 26, 2023
Contributor
eccabay
left a comment
eccabay
left a comment
There was a problem hiding this comment.
Looks good! The documentation is much easier to understand. Just a couple typos, but otherwise let's 🚢
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.