Remove requirements-parser and tomli from core requirements #3948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsheni
commented
Jan 20, 2023
| @@ -25,12 +25,7 @@ jobs: | |||
| repository: ${{ github.event.pull_request.head.repo.full_name }} | |||
| - name: Install Dependencies | |||
| run: | | |||
| pip install virtualenv | |||
There was a problem hiding this comment.
virtualenv are unnecessary for CI environments.
Codecov Report
@@ Coverage Diff @@
## main #3948 +/- ##
=====================================
Coverage 99.7% 99.7%
=====================================
Files 347 347
Lines 36755 36755
=====================================
Hits 36625 36625
Misses 130 130
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
added 2 commits
January 20, 2023 15:07
gsheni
commented
Jan 20, 2023
| @@ -155,12 +155,13 @@ select = [ | |||
| # isort | |||
| "I001" | |||
| ] | |||
| ignore = ["E501", "D107"] | |||
| ignore = ["E501", "D107", "D401"] | |||
| src = ["evalml"] | |||
|
|
|||
| [tool.ruff.per-file-ignores] | |||
| "__init__.py" = ["E402", "F401", "I001", "E501"] | |||
| "evalml/tests/**" = ["D"] | |||
There was a problem hiding this comment.
D means to check for pydocstyle (Python docstring conventions)
This makes it ignore docstrings in these directories.
chukarsten
approved these changes
Jan 23, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.