Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip featurization for time series native models #3964

Merged
merged 6 commits into from
Jan 31, 2023

Conversation

eccabay
Copy link
Contributor

@eccabay eccabay commented Jan 30, 2023

Re-adding #3849 after woodwork's schema bug was resolved, now with a test to ensure we shouldn't encounter the same issue again.

@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Merging #3964 (a973911) into main (9b4ff1b) will increase coverage by 13.1%.
The diff coverage is 100.0%.

@@           Coverage Diff            @@
##            main   #3964      +/-   ##
========================================
+ Coverage   86.7%   99.7%   +13.1%     
========================================
  Files        347     347              
  Lines      36790   36801      +11     
========================================
+ Hits       31876   36681    +4805     
+ Misses      4914     120    -4794     
Impacted Files Coverage Δ
evalml/pipelines/time_series_pipeline_base.py 100.0% <100.0%> (ø)
.../integration_tests/test_time_series_integration.py 100.0% <100.0%> (ø)
evalml/utils/gen_utils.py 99.3% <0.0%> (+0.4%) ⬆️
evalml/tests/conftest.py 98.2% <0.0%> (+0.8%) ⬆️
...rmers/preprocessing/natural_language_featurizer.py 98.9% <0.0%> (+1.2%) ⬆️
evalml/pipelines/pipeline_base.py 98.5% <0.0%> (+2.2%) ⬆️
...components/transformers/encoders/target_encoder.py 100.0% <0.0%> (+2.5%) ⬆️
evalml/pipelines/components/component_base.py 100.0% <0.0%> (+3.1%) ⬆️
evalml/exceptions/exceptions.py 100.0% <0.0%> (+3.1%) ⬆️
evalml/model_family/model_family.py 100.0% <0.0%> (+7.7%) ⬆️
... and 25 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@eccabay eccabay marked this pull request as ready for review January 30, 2023 20:42
Copy link
Collaborator

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chukarsten chukarsten enabled auto-merge (squash) January 31, 2023 16:18
@chukarsten chukarsten merged commit a409e17 into main Jan 31, 2023
@chukarsten chukarsten deleted the 442_skip_featurization branch January 31, 2023 16:44
@chukarsten chukarsten mentioned this pull request Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants