Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cap XGBoost < 1.0.0 #402

Merged
merged 3 commits into from Feb 20, 2020
Merged

Cap XGBoost < 1.0.0 #402

merged 3 commits into from Feb 20, 2020

Conversation

jeremyliweishih
Copy link
Contributor

@jeremyliweishih jeremyliweishih commented Feb 20, 2020

XGBoost 1.0.0 breaks on python 3.5 and causes our tests to timeout on other python versions. Let's cap for now and discuss further in #401 for other versioning methods.

@codecov
Copy link

codecov bot commented Feb 20, 2020

Codecov Report

Merging #402 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #402   +/-   ##
=======================================
  Coverage   97.37%   97.37%           
=======================================
  Files         103      103           
  Lines        3195     3195           
=======================================
  Hits         3111     3111           
  Misses         84       84

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5c4039...a31db3d. Read the comment docs.

Copy link
Contributor

@angela97lin angela97lin left a comment

🥘

@jeremyliweishih jeremyliweishih merged commit bec56ef into master Feb 20, 2020
2 checks passed
christopherbunn added a commit that referenced this pull request Feb 21, 2020
christopherbunn added a commit that referenced this pull request Mar 2, 2020
@angela97lin angela97lin mentioned this pull request Mar 9, 2020
@dsherry dsherry deleted the cap_xg branch May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants