Avoid dfs transformer checking in feat importance fast mode check if pipline is stacked ensemble #4083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamargrey
commented
Mar 17, 2023
| if has_dfs: | ||
| # If the pipeline is a stacked ensemble, the DFS Transformer name will be different | ||
| # and we don't need to check for the pre_existing features anyway | ||
| if has_dfs and not has_more_than_one_estimator: |
There was a problem hiding this comment.
The other option for fixing was to change self.component_graph[DFSTransformer.name] to use whatever name is actually being used in the component graph for the dfs transformer(s), but I don't know of any other way the name could be anything other than "DFS Transformer" other than the stacked ensemble case, so this seemed simpler.
Codecov Report
@@ Coverage Diff @@
## main #4083 +/- ##
=====================================
Coverage 99.7% 99.7%
=====================================
Files 349 349
Lines 37548 37548
=====================================
Hits 37429 37429
Misses 119 119
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
fjlanasa
approved these changes
Mar 17, 2023
christopherbunn
approved these changes
Mar 17, 2023
ozzieD
approved these changes
Mar 17, 2023
chukarsten
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4082