Skip to content

Add all support for Target Leakage #4106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 11, 2023
Merged

Add all support for Target Leakage #4106

merged 7 commits into from
Apr 11, 2023

Conversation

bchen1116
Copy link
Contributor

@bchen1116 bchen1116 commented Mar 24, 2023

fix #4107

@bchen1116 bchen1116 self-assigned this Mar 24, 2023
@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Merging #4106 (a9bf076) into main (b28026c) will increase coverage by 0.1%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main   #4106     +/-   ##
=======================================
+ Coverage   99.7%   99.7%   +0.1%     
=======================================
  Files        349     349             
  Lines      37752   37770     +18     
=======================================
+ Hits       37635   37653     +18     
  Misses       117     117             
Impacted Files Coverage Δ
evalml/data_checks/target_leakage_data_check.py 94.9% <100.0%> (-0.1%) ⬇️
...ata_checks_tests/test_target_leakage_data_check.py 100.0% <100.0%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@christopherbunn christopherbunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested additional test case, but once that is addressed LGTM

Copy link
Collaborator

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chukarsten chukarsten enabled auto-merge (squash) April 11, 2023 15:54
@chukarsten chukarsten merged commit b119ad3 into main Apr 11, 2023
@chukarsten chukarsten deleted the TML-6816-all branch April 11, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support to all for TargetLeakageDataCheck
4 participants