Skip to content

Added BytesIO support to PipelineBase.load()#4179

Merged
chukarsten merged 6 commits into
mainfrom
OSSEVALML-579_PipelineBase_load-BytesIO
May 9, 2023
Merged

Added BytesIO support to PipelineBase.load()#4179
chukarsten merged 6 commits into
mainfrom
OSSEVALML-579_PipelineBase_load-BytesIO

Conversation

@cp2boston

@cp2boston cp2boston commented May 8, 2023

Copy link
Copy Markdown
Contributor

Pull Request Description

Added support for BytesIO input to PipelineBase.load(), primarily to support VFS

Fixes #4178

@CLAassistant

CLAassistant commented May 8, 2023

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@codecov

codecov Bot commented May 8, 2023

Copy link
Copy Markdown

Codecov Report

Merging #4179 (2469770) into main (ee540f1) will increase coverage by 0.1%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main   #4179     +/-   ##
=======================================
+ Coverage   99.7%   99.7%   +0.1%     
=======================================
  Files        349     349             
  Lines      37797   37809     +12     
=======================================
+ Hits       37680   37692     +12     
  Misses       117     117             
Impacted Files Coverage Δ
evalml/pipelines/pipeline_base.py 98.5% <100.0%> (+0.1%) ⬆️
evalml/tests/pipeline_tests/test_pipelines.py 99.9% <100.0%> (+0.1%) ⬆️

@cp2boston cp2boston changed the title OSSEVALML-579 Added BytesIO support to PipelineBase.load() Added BytesIO support to PipelineBase.load() May 8, 2023
@cp2boston cp2boston requested a review from chukarsten May 8, 2023 19:11
@cp2boston cp2boston requested a review from jeremyliweishih May 9, 2023 13:55

@jeremyliweishih jeremyliweishih left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit but otherwise LGTM!

Comment thread evalml/tests/pipeline_tests/test_pipelines.py
@chukarsten chukarsten merged commit b530abd into main May 9, 2023
@chukarsten chukarsten deleted the OSSEVALML-579_PipelineBase_load-BytesIO branch May 9, 2023 16:46
@chukarsten chukarsten mentioned this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update PipelineBase.load() to accept both a path and a file-like object

4 participants