Skip to content

Add check_distribution function #4184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 26, 2023
Merged

Add check_distribution function #4184

merged 5 commits into from
May 26, 2023

Conversation

eccabay
Copy link
Contributor

@eccabay eccabay commented May 11, 2023

Closes #4170

@codecov
Copy link

codecov bot commented May 11, 2023 •
edited
Loading

Codecov Report

Merging #4184 (a510c27) into main (c60f712) will increase coverage by 0.1%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main   #4184     +/-   ##
=======================================
+ Coverage   99.7%   99.7%   +0.1%     
=======================================
  Files        349     349             
  Lines      38128   38154     +26     
=======================================
+ Hits       38011   38037     +26     
  Misses       117     117
Impacted Files Coverage Δ
evalml/model_understanding/metrics.py 100.0% <100.0%> (ø)
...ml/tests/model_understanding_tests/test_metrics.py 100.0% <100.0%> (ø)

@eccabay eccabay marked this pull request as ready for review May 23, 2023 20:03
jeremyliweishih
jeremyliweishih approved these changes May 23, 2023
View reviewed changes
Copy link
Collaborator

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once we add the baseline case for coverage

evalml/tests/model_understanding_tests/test_metrics.py
def test_check_distribution(problem_type, expected_distribution):
y_true = pd.Series(np.random.normal(size=500))
if expected_distribution == "matching":
y_pred = pd.Series(np.random.normal(size=500))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would we want to test non-normal distributions?

chukarsten
chukarsten approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@chukarsten chukarsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Well done.

@eccabay eccabay enabled auto-merge (squash) May 26, 2023 14:08
@eccabay eccabay merged commit 437a17a into main May 26, 2023
@eccabay eccabay deleted the 4170_check_dist_func branch May 26, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremyliweishih jeremyliweishih jeremyliweishih approved these changes

@chukarsten chukarsten chukarsten approved these changes

@christopherbunn christopherbunn Awaiting requested review from christopherbunn

@fjlanasa fjlanasa Awaiting requested review from fjlanasa

Assignees

@eccabay eccabay

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement check_distribution function for pipelines
3 participants
@eccabay @jeremyliweishih @chukarsten