Repository navigation
Add check_distribution function - #4184
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4184 +/- ##
=======================================
+ Coverage 99.7% 99.7% +0.1%
=======================================
Files 349 349
Lines 38128 38154 +26
=======================================
+ Hits 38011 38037 +26
Misses 117 117
|
eccabay
marked this pull request as ready for review
May 23, 2023 20:03
eccabay
requested review from
christopherbunn,
chukarsten,
fjlanasa and
jeremyliweishih
May 23, 2023 20:03
jeremyliweishih
approved these changes
May 23, 2023
jeremyliweishih
left a comment
jeremyliweishih
left a comment
Collaborator
There was a problem hiding this comment.
LGTM once we add the baseline case for coverage
| def test_check_distribution(problem_type, expected_distribution): | ||
| y_true = pd.Series(np.random.normal(size=500)) | ||
| if expected_distribution == "matching": | ||
| y_pred = pd.Series(np.random.normal(size=500)) |
Collaborator
There was a problem hiding this comment.
would we want to test non-normal distributions?
chukarsten
approved these changes
May 24, 2023
chukarsten
left a comment
chukarsten
left a comment
Contributor
There was a problem hiding this comment.
Looks great! Well done.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4170