Skip to content

Exclude time index in IDColumnsDataCheck - #4194

Merged
jeff-hernandez merged 8 commits into
mainfrom
exclude_time_index
Jun 6, 2023
Merged

Exclude time index in IDColumnsDataCheck#4194
jeff-hernandez merged 8 commits into
mainfrom
exclude_time_index

Conversation

@jeff-hernandez

Copy link
Copy Markdown
Contributor

@jeff-hernandez
jeff-hernandez marked this pull request as ready for review May 30, 2023 19:57
@codecov

codecov Bot commented May 30, 2023

Copy link
Copy Markdown

Codecov Report

Merging #4194 (12f3733) into main (1cdc15b) will increase coverage by 0.1%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main   #4194     +/-   ##
=======================================
+ Coverage   99.7%   99.7%   +0.1%     
=======================================
  Files        349     349             
  Lines      38154   38159      +5     
=======================================
+ Hits       38037   38042      +5     
  Misses       117     117             
Impacted Files Coverage Δ
evalml/data_checks/id_columns_data_check.py 100.0% <100.0%> (ø)
...ts/data_checks_tests/test_id_columns_data_check.py 100.0% <100.0%> (ø)

Comment thread docs/source/release_notes.rst Outdated
Comment thread evalml/tests/data_checks_tests/test_id_columns_data_check.py Outdated
@jeff-hernandez
jeff-hernandez requested a review from bchen1116 June 1, 2023 17:48

@ParthivNaresh ParthivNaresh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid

@simha104 simha104 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeff-hernandez
jeff-hernandez merged commit 1591ca7 into main Jun 6, 2023
@jeff-hernandez
jeff-hernandez deleted the exclude_time_index branch June 6, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add option to exclude time index from IDColumnsDataCheck

5 participants