Skip to content

Exclude time index in IDColumnsDataCheck #4194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 6, 2023
Merged

Exclude time index in IDColumnsDataCheck #4194

merged 8 commits into from
Jun 6, 2023

Conversation

jeff-hernandez
Copy link
Contributor

@jeff-hernandez jeff-hernandez marked this pull request as ready for review May 30, 2023 19:57
@codecov
Copy link

codecov bot commented May 30, 2023 •
edited
Loading

Codecov Report

Merging #4194 (12f3733) into main (1cdc15b) will increase coverage by 0.1%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main   #4194     +/-   ##
=======================================
+ Coverage   99.7%   99.7%   +0.1%     
=======================================
  Files        349     349             
  Lines      38154   38159      +5     
=======================================
+ Hits       38037   38042      +5     
  Misses       117     117
Impacted Files Coverage Δ
evalml/data_checks/id_columns_data_check.py 100.0% <100.0%> (ø)
...ts/data_checks_tests/test_id_columns_data_check.py 100.0% <100.0%> (ø)

bchen1116
bchen1116 reviewed May 31, 2023
View reviewed changes
bchen1116
bchen1116 reviewed May 31, 2023
View reviewed changes
@jeff-hernandez jeff-hernandez requested a review from bchen1116 June 1, 2023 17:48
ParthivNaresh
ParthivNaresh approved these changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@ParthivNaresh ParthivNaresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid

simha104
simha104 approved these changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@simha104 simha104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeff-hernandez jeff-hernandez merged commit 1591ca7 into main Jun 6, 2023
@jeff-hernandez jeff-hernandez deleted the exclude_time_index branch June 6, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bchen1116 bchen1116 bchen1116 approved these changes

@ParthivNaresh ParthivNaresh ParthivNaresh approved these changes

@simha104 simha104 simha104 approved these changes

Assignees

@jeff-hernandez jeff-hernandez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add option to exclude time index from IDColumnsDataCheck
5 participants
@jeff-hernandez @bchen1116 @ParthivNaresh @simha104 @chukarsten