-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added excluded_model_families
parameter to AutoMLSearch()
#4196
Conversation
exclude_model_families
parameter to AutoMLSearch()
exclude_model_families
parameter to AutoMLSearch()
Codecov Report
@@ Coverage Diff @@
## main #4196 +/- ##
=======================================
- Coverage 99.7% 99.7% -0.0%
=======================================
Files 349 349
Lines 38159 38229 +70
=======================================
+ Hits 38042 38111 +69
- Misses 117 118 +1
|
@christopherbunn what are your thoughts on removing If we don't, it may be possible to introduce some weird conflicts using the iterative algorithm where a model family is simultaneously allowed and disallowed. It's been a weird, semi-deprecated argument for a while anyways, since it's only usable in the iterative algorithm case but we still allow users to set it in the default algorithm case. Open to discussion, of course. |
exclude_model_families
parameter to AutoMLSearch()
excluded_model_families
parameter to AutoMLSearch()
@eccabay re: |
bb94287
to
285999e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just have some nits about our handling of the "not set" case
2ea42a0
to
c0a13c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just wondering if we should centralize the validation of allowing and excluding model families. LMK what you think!
e8368af
to
16395bd
Compare
Resolves #4197