Skip to content

update get_forecast_distance to handle gap#4200

Merged
chukarsten merged 5 commits intomainfrom
fix_get_forecast_period
Jun 7, 2023
Merged

update get_forecast_distance to handle gap#4200
chukarsten merged 5 commits intomainfrom
fix_get_forecast_period

Conversation

@fjlanasa
Copy link
Contributor

@fjlanasa fjlanasa commented Jun 6, 2023

Pull Request Description

Resolves #4201

This updates get_forecast_period to account for the gap parameter, so we only show predictions for X[-1] + gap to forecast_horizon.


After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #4200 (8455d93) into main (af53c15) will not change coverage.
The diff coverage is 100.0%.

@@          Coverage Diff          @@
##            main   #4200   +/-   ##
=====================================
  Coverage   99.7%   99.7%           
=====================================
  Files        349     349           
  Lines      38229   38229           
=====================================
  Hits       38111   38111           
  Misses       118     118           
Impacted Files Coverage Δ
...valml/pipelines/time_series_regression_pipeline.py 100.0% <ø> (ø)
...peline_tests/test_time_series_baseline_pipeline.py 100.0% <100.0%> (ø)

Copy link
Collaborator

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fjlanasa fjlanasa changed the title fix get_forecast_distance to properly handle gap update get_forecast_distance to handle gap Jun 7, 2023
@chukarsten chukarsten merged commit 1cd5e5b into main Jun 7, 2023
@chukarsten chukarsten deleted the fix_get_forecast_period branch June 7, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix get_forecast_period to properly account for gap

3 participants