Skip to content

Remove Decision Tree and CatBoost Estimators from AutoML search - #4205

Merged
christopherbunn merged 8 commits into
mainfrom
TML-7576_Remove_Estimators
Jun 14, 2023
Merged

Remove Decision Tree and CatBoost Estimators from AutoML search#4205
christopherbunn merged 8 commits into
mainfrom
TML-7576_Remove_Estimators

Conversation

@christopherbunn

@christopherbunn christopherbunn commented Jun 8, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Resolves #4207, Resolves #4208

@codecov

codecov Bot commented Jun 8, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #4205 (8b4245e) into main (d95ba3e) will decrease coverage by 0.0%.
The diff coverage is 93.4%.

@@           Coverage Diff           @@
##            main   #4205     +/-   ##
=======================================
- Coverage   99.7%   99.7%   -0.0%     
=======================================
  Files        349     349             
  Lines      38229   38229             
=======================================
- Hits       38111   38109      -2     
- Misses       118     120      +2
Impacted Files Coverage Δ
...lml/tests/automl_tests/test_iterative_algorithm.py 100.0% <ø> (ø)
evalml/utils/gen_utils.py 99.3% <ø> (ø)
evalml/tests/pipeline_tests/test_pipelines.py 99.9% <50.0%> (ø)
evalml/tests/automl_tests/test_automl.py 99.5% <100.0%> (-<0.1%) ⬇️
.../automl_tests/test_automl_search_classification.py 96.4% <100.0%> (ø)
evalml/tests/pipeline_tests/test_pipeline_utils.py 99.6% <100.0%> (ø)
evalml/tests/utils_tests/test_logger.py 100.0% <100.0%> (ø)

@christopherbunn
christopherbunn force-pushed the TML-7576_Remove_Estimators branch 2 times, most recently from ed95385 to 12cbba7 Compare June 13, 2023 15:46
@christopherbunn
christopherbunn force-pushed the TML-7576_Remove_Estimators branch from 12cbba7 to 7f4865f Compare June 13, 2023 15:47
@christopherbunn
christopherbunn marked this pull request as ready for review June 13, 2023 15:58
jeremyliweishih
jeremyliweishih approved these changes Jun 13, 2023
View reviewed changes

@jeremyliweishih jeremyliweishih left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

christopherbunn
christopherbunn commented Jun 13, 2023
View reviewed changes
Comment thread evalml/tests/pipeline_tests/test_pipelines.py
):
if is_using_conda:
n_estimators = 17
n_estimators = 13

@christopherbunn christopherbunn Jun 13, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this typically gets covered with our existing CI right?

@jeremyliweishih jeremyliweishih Jun 13, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe so

eccabay
eccabay approved these changes Jun 14, 2023
View reviewed changes
Comment thread docs/source/demos/lead_scoring.ipynb Outdated
{
"cells": [
{
"attachments": {},

@eccabay eccabay Jun 14, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea why these got added here and removed from timeseries.ipynb?

@christopherbunn christopherbunn Jun 14, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I think it's thrown in when you open the ipynb in VSCode. I thought I manually deleted some of these before I pushed. I'll take these added ones out and keep the removed ones in timeseries.ipynb!

Comment thread docs/source/release_notes.rst Outdated
* Enhancements
* Fixes
* Changes
* Remove Decision Tree and CatBoost Estimators from AutoML search :pr:`4205`

@eccabay eccabay Jun 14, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Remove -> Removed 😁

Also, thoughts on classifying this as a breaking change, since it's a pretty major removal?

@christopherbunn christopherbunn Jun 14, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will add another entry to point this out!

@christopherbunn
christopherbunn enabled auto-merge (squash) June 14, 2023 15:38
@christopherbunn
christopherbunn merged commit 6c5e9c8 into main Jun 14, 2023
@christopherbunn
christopherbunn deleted the TML-7576_Remove_Estimators branch June 14, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeremyliweishih jeremyliweishih jeremyliweishih approved these changes
@fjlanasa fjlanasa Awaiting requested review from fjlanasa
@chukarsten chukarsten Awaiting requested review from chukarsten
+1 more reviewer
@eccabay eccabay eccabay approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@christopherbunn christopherbunn

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove DecisionTree for all Problem Types Remove CatBoost for all Problem Types

3 participants

@christopherbunn @jeremyliweishih @eccabay