-
Notifications
You must be signed in to change notification settings - Fork 89
Remove Decision Tree and CatBoost Estimators from AutoML search #4205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4205 +/- ##
=======================================
- Coverage 99.7% 99.7% -0.0%
=======================================
Files 349 349
Lines 38229 38229
=======================================
- Hits 38111 38109 -2
- Misses 118 120 +2
|
ed95385
to
12cbba7
Compare
12cbba7
to
7f4865f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -115,9 +113,9 @@ def test_all_estimators( | |||
is_using_conda, | |||
): | |||
if is_using_conda: | |||
n_estimators = 17 | |||
n_estimators = 13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this typically gets covered with our existing CI right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't believe so
docs/source/demos/lead_scoring.ipynb
Outdated
@@ -1,6 +1,7 @@ | |||
{ | |||
"cells": [ | |||
{ | |||
"attachments": {}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any idea why these got added here and removed from timeseries.ipynb?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I think it's thrown in when you open the ipynb in VSCode. I thought I manually deleted some of these before I pushed. I'll take these added ones out and keep the removed ones in timeseries.ipynb
!
docs/source/release_notes.rst
Outdated
@@ -4,6 +4,7 @@ Release Notes | |||
* Enhancements | |||
* Fixes | |||
* Changes | |||
* Remove Decision Tree and CatBoost Estimators from AutoML search :pr:`4205` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Remove -> Removed 😁
Also, thoughts on classifying this as a breaking change, since it's a pretty major removal?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will add another entry to point this out!
Resolves #4207, Resolves #4208