Skip to content

Removed first batch from default algorithm - #4215

Merged
christopherbunn merged 6 commits into
mainfrom
TML-7230
Jul 11, 2023
Merged

christopherbunn merged 6 commits into
mainfrom
TML-7230

Conversation

@christopherbunn

@christopherbunn christopherbunn commented Jun 28, 2023 •

Copy link
Copy Markdown
Contributor

Resolves #4219

@codecov

codecov Bot commented Jun 28, 2023 •

Copy link
Copy Markdown

Codecov Report

Merging #4215 (5a0f530) into main (2481ed1) will increase coverage by 15.3%.
The diff coverage is 100.0%.

@@           Coverage Diff            @@
##            main   #4215      +/-   ##
========================================
+ Coverage   84.4%   99.7%   +15.3%     
========================================
  Files        349     349              
  Lines      38294   38284      -10     
========================================
+ Hits       32320   38165    +5845     
+ Misses      5974     119    -5855     
Impacted Files Coverage Δ
.../automl_tests/test_automl_search_classification.py 96.4% <ø> (+96.4%) ⬆️
...valml/automl/automl_algorithm/default_algorithm.py 99.7% <100.0%> (+26.9%) ⬆️
evalml/automl/automl_search.py 99.8% <100.0%> (+35.7%) ⬆️
evalml/tests/automl_tests/test_automl.py 99.5% <100.0%> (+99.5%) ⬆️
...valml/tests/automl_tests/test_default_algorithm.py 100.0% <100.0%> (+100.0%) ⬆️
evalml/tests/automl_tests/test_search.py 100.0% <100.0%> (+100.0%) ⬆️
evalml/tests/pipeline_tests/test_pipeline_utils.py 99.6% <100.0%> (ø)

... and 30 files with indirect coverage changes

@christopherbunn christopherbunn changed the title Remove first batch from Default Algorithm Removed first batch from default algorithm Jun 30, 2023
@christopherbunn
christopherbunn marked this pull request as ready for review June 30, 2023 18:08

@jeremyliweishih jeremyliweishih left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherbunn
christopherbunn enabled auto-merge (squash) June 30, 2023 18:32
@christopherbunn
christopherbunn disabled auto-merge June 30, 2023 18:32

@eccabay eccabay left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nitpicks but otherwise looks great!

Comment thread evalml/automl/automl_algorithm/default_algorithm.py
Comment thread docs/source/start.ipynb Outdated
Comment thread evalml/tests/automl_tests/test_automl.py Outdated
Comment on lines -1822 to +1825
assert "Label Encoder" in pipeline_error["Parameters"]
assert (
"Label Encoder" in pipeline_error["Parameters"]
or "Mock Classifier" in pipeline_error["Parameters"]
)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question here, why did this have to change?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously, our mock didn't actually work. We now check to see that the mock classifier pipelines appear in the results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove DefaultAlgorithm Batch 1

3 participants