Repository navigation
Removed first batch from default algorithm - #4215
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4215 +/- ##
========================================
+ Coverage 84.4% 99.7% +15.3%
========================================
Files 349 349
Lines 38294 38284 -10
========================================
+ Hits 32320 38165 +5845
+ Misses 5974 119 -5855
|
christopherbunn
marked this pull request as ready for review
June 30, 2023 18:08
christopherbunn
requested review from
chukarsten,
eccabay,
fjlanasa,
jeremyliweishih and
remyogasawara
June 30, 2023 18:09
christopherbunn
enabled auto-merge (squash)
June 30, 2023 18:32
christopherbunn
disabled auto-merge
June 30, 2023 18:32
eccabay
approved these changes
Jun 30, 2023
eccabay
left a comment
Contributor
There was a problem hiding this comment.
Just a few nitpicks but otherwise looks great!
Comment on lines
-1822
to
+1825
| assert "Label Encoder" in pipeline_error["Parameters"] | ||
| assert ( | ||
| "Label Encoder" in pipeline_error["Parameters"] | ||
| or "Mock Classifier" in pipeline_error["Parameters"] | ||
| ) |
Contributor
There was a problem hiding this comment.
Same question here, why did this have to change?
Contributor
Author
There was a problem hiding this comment.
Previously, our mock didn't actually work. We now check to see that the mock classifier pipelines appear in the results.
christopherbunn
enabled auto-merge (squash)
July 6, 2023 20:36
christopherbunn
force-pushed
the
TML-7230
branch
3 times, most recently
from
July 11, 2023 15:43
c1e1132 to
975e275
Compare
christopherbunn
force-pushed
the
TML-7230
branch
from
July 11, 2023 18:23
975e275 to
5a0f530
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4219