Upgrade LightGBM and remove nullable handling - #4237
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4237 +/- ##
========================================
+ Coverage 84.5% 99.7% +15.3%
========================================
Files 349 349
Lines 38314 38281 -33
========================================
+ Hits 32344 38162 +5818
+ Misses 5970 119 -5851
|
eccabay
marked this pull request as ready for review
July 14, 2023 15:46
eccabay
requested review from
MichaelFu512,
christopherbunn,
jeremyliweishih,
remyogasawara and
tamargrey
July 14, 2023 15:46
tamargrey
approved these changes
Jul 14, 2023
tamargrey
left a comment
tamargrey
left a comment
Contributor
There was a problem hiding this comment.
Glad things work as expected!! LGTM
remyogasawara
pushed a commit
that referenced
this pull request
Jul 14, 2023
* Remove nullable type incompatibility tests * Remove nullable type handling from lightgbm * Bump min lightgbm version to 4.0.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4017
Shoutout to @tamargrey for making this so easy