Skip to content

Upgrade scikit-learn - #4248

Merged
eccabay merged 13 commits into
mainfrom
4247_sklearn_upgrade
Jul 24, 2023
Merged

Upgrade scikit-learn#4248
eccabay merged 13 commits into
mainfrom
4247_sklearn_upgrade

Conversation

@eccabay

@eccabay eccabay commented Jul 20, 2023

Copy link
Copy Markdown
Contributor

Closes #4247

** New and improved **
Upgrades to the most recent versions of scikit-learn and imbalanced-learn, plus updating sktime and vowpal-wabbit.

** Previous **
The newest version of scikit-learn is incompatible with the version of imbalanced-learn that we're pinned to. Unfortunately, imbalanced-learn must remain pinned due to lack of nullable type handling, so we can't upgrade scikit-learn. Once imbalanced-learn fixes their nullable type issues, we should be able to unpin both.

Nonetheless, this includes changes to Decision Tree and Extra Trees estimators to remove a deprecated "auto" argument that will be fully removed once we do upgrade to 1.3.0.

@codecov

codecov Bot commented Jul 20, 2023

Copy link
Copy Markdown

Codecov Report

Merging #4248 (961e1fe) into main (5e158ed) will increase coverage by 0.1%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main   #4248     +/-   ##
=======================================
+ Coverage   99.7%   99.7%   +0.1%     
=======================================
  Files        349     349             
  Lines      38309   38320     +11     
=======================================
+ Hits       38190   38201     +11     
  Misses       119     119             
Impacted Files Coverage Δ
evalml/pipelines/component_graph.py 99.8% <ø> (ø)
...components/ensemble/stacked_ensemble_classifier.py 100.0% <ø> (ø)
...estimators/classifiers/decision_tree_classifier.py 100.0% <ø> (ø)
...components/estimators/classifiers/et_classifier.py 100.0% <ø> (ø)
...s/estimators/regressors/decision_tree_regressor.py 100.0% <ø> (ø)
...s/components/estimators/regressors/et_regressor.py 100.0% <ø> (ø)
evalml/pipelines/components/utils.py 96.5% <ø> (ø)
...ts/estimators/classifiers/kneighbors_classifier.py 100.0% <100.0%> (ø)
evalml/tests/component_tests/test_components.py 99.1% <100.0%> (ø)
...s/component_tests/test_decision_tree_classifier.py 100.0% <100.0%> (ø)
... and 6 more

@eccabay
eccabay marked this pull request as ready for review July 21, 2023 12:21

@jeremyliweishih jeremyliweishih left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment thread docs/source/release_notes.rst
@eccabay

eccabay commented Jul 21, 2023

Copy link
Copy Markdown
Contributor Author

In further investigation of the imbalanced-learn error that caused its pinning, I found a workaround since the error is just in one of our tests.

Pausing review on this PR until I can determine if this workaround allows me to unpin imbalanced-learn as well as upgrade scikit-learn instead of pinning it.

@eccabay
eccabay marked this pull request as draft July 21, 2023 15:54
@eccabay

eccabay commented Jul 21, 2023

Copy link
Copy Markdown
Contributor Author

Looks like this is blocked until conda-forge/sktime-feedstock#94 is merged

@eccabay
eccabay marked this pull request as ready for review July 21, 2023 19:58
@fkiraly

fkiraly commented Jul 23, 2023

Copy link
Copy Markdown

Looks like this is blocked until conda-forge/sktime-feedstock#94 is merged

No longer blocked :-)

@eccabay
eccabay requested a review from chukarsten July 24, 2023 13:37
@eccabay eccabay changed the title Pin scikit-learn Upgrade scikit-learn Jul 24, 2023

@chukarsten chukarsten left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@eccabay
eccabay merged commit 0c224ea into main Jul 24, 2023
@eccabay
eccabay deleted the 4247_sklearn_upgrade branch July 24, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Resolve scikit-learn 1.3.0 upgrade

4 participants