Add stacking and unstacking utils for multiseries - #4250
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4250 +/- ##
=======================================
+ Coverage 99.7% 99.7% +0.1%
=======================================
Files 349 349
Lines 38320 38410 +90
=======================================
+ Hits 38201 38291 +90
Misses 119 119
|
eccabay
marked this pull request as ready for review
July 24, 2023 20:57
eccabay
requested review from
MichaelFu512,
christopherbunn,
chukarsten,
jeremyliweishih and
remyogasawara
and removed request for
christopherbunn and
jeremyliweishih
July 24, 2023 20:57
jeremyliweishih
approved these changes
Jul 25, 2023
jeremyliweishih
left a comment
jeremyliweishih
left a comment
Collaborator
There was a problem hiding this comment.
LGTM just have some questions and a potential impl improvement for unstacking
chukarsten
approved these changes
Jul 26, 2023
chukarsten
left a comment
chukarsten
left a comment
Contributor
There was a problem hiding this comment.
Looks good, a nit and a suggestion here and there but has the stamp of approval!
Co-authored-by: chukarsten <64713315+chukarsten@users.noreply.github.com>
remyogasawara
pushed a commit
that referenced
this pull request
Aug 2, 2023
* Add unstacking function * Add stacking function * Add tests for both functions
remyogasawara
pushed a commit
that referenced
this pull request
Aug 2, 2023
* Add unstacking function * Add stacking function * Add tests for both functions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4249