Fixed Data Checks errors#4274
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4274 +/- ##
=====================================
Coverage 99.7% 99.7%
=====================================
Files 355 355
Lines 38956 38956
=====================================
Hits 38835 38835
Misses 121 121 |
remyogasawara
force-pushed
the
4212_data_checks_errors
branch
from
b5dcdc1 to
1638869
Compare
remyogasawara
requested review from
MichaelFu512,
christopherbunn,
chukarsten,
eccabay,
fjlanasa and
jeremyliweishih
MichaelFu512
approved these changes
Aug 15, 2023
eccabay
reviewed
Aug 16, 2023
eccabay
left a comment
eccabay
left a comment
Contributor
There was a problem hiding this comment.
Awesome! Just a note about the release note, but otherwise looks good
jeremyliweishih
approved these changes
Aug 16, 2023
jeremyliweishih
left a comment
jeremyliweishih
left a comment
Collaborator
There was a problem hiding this comment.
LGTM pending Becca's comment!
remyogasawara
commented
Aug 17, 2023
| @@ -1,3 +1,6 @@ | |||
| # flake8: noqa 401 imported to force console mode for tqdm in jupyter notebooks | |||
| from tqdm.auto import tqdm | |||
Contributor
Author
There was a problem hiding this comment.
Also added this import to get rid of this error Using 'tqdm.autonotebook.tqdm' in notebook mode. Use 'tqdm.tqdm' instead to force console mode (e.g. in jupyter console) that appears in all the notebooks. Let me know if you think we should add it to a different file or anything
jeremyliweishih
approved these changes
Aug 18, 2023
remyogasawara
force-pushed
the
4212_data_checks_errors
branch
from
12911f8 to
90524ee
Compare
MichaelFu512
approved these changes
Aug 18, 2023
christopherbunn
approved these changes
Aug 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4212