Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change score output to return one dictionary #429

Merged
merged 47 commits into from Mar 4, 2020

Conversation

angela97lin
Copy link
Contributor

@angela97lin angela97lin commented Feb 28, 2020

Closes #428 after #404 is merged into improved_objectives branch.

@angela97lin angela97lin changed the title Change score output to return one dictionary [WIP] Change score output to return one dictionary Feb 28, 2020
@codecov
Copy link

codecov bot commented Feb 28, 2020

Codecov Report

No coverage uploaded for pull request base (improved_objectives@c75499a). Click here to learn what that means.
The diff coverage is 94.68%.

Impacted file tree graph

@@                  Coverage Diff                   @@
##             improved_objectives     #429   +/-   ##
======================================================
  Coverage                       ?   97.44%           
======================================================
  Files                          ?      113           
  Lines                          ?     3482           
  Branches                       ?        0           
======================================================
  Hits                           ?     3393           
  Misses                         ?       89           
  Partials                       ?        0
Impacted Files Coverage Δ
evalml/objectives/utils.py 94.44% <ø> (ø)
...ts/automl_tests/test_auto_classification_search.py 100% <ø> (ø)
evalml/tests/pipeline_tests/test_pipelines.py 100% <100%> (ø)
...l/tests/automl_tests/test_pipeline_search_plots.py 97.05% <100%> (ø)
evalml/objectives/standard_metrics.py 99.57% <100%> (ø)
evalml/automl/auto_base.py 93.2% <100%> (ø)
...ression_pipeline_tests/test_catboost_regression.py 100% <100%> (ø)
evalml/pipelines/binary_classification_pipeline.py 100% <100%> (ø)
evalml/automl/auto_classification_search.py 100% <100%> (ø)
...ts/regression_pipeline_tests/test_rf_regression.py 100% <100%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c75499a...99a1547. Read the comment docs.

@angela97lin angela97lin changed the base branch from improved_objectives to 404_separated_pipelines Feb 28, 2020
@angela97lin angela97lin changed the title [WIP] Change score output to return one dictionary Change score output to return one dictionary Feb 28, 2020
@angela97lin angela97lin requested a review from dsherry Feb 28, 2020
dsherry
dsherry approved these changes Mar 3, 2020
Copy link
Collaborator

@dsherry dsherry left a comment

Left one testing suggestion, otherwise looks great!

@angela97lin angela97lin changed the base branch from 404_separated_pipelines to improved_objectives Mar 3, 2020
@angela97lin angela97lin merged commit 1ca6769 into improved_objectives Mar 4, 2020
2 checks passed
@angela97lin angela97lin deleted the 428_score_output branch Mar 4, 2020
@angela97lin angela97lin restored the 428_score_output branch Mar 26, 2020
@angela97lin angela97lin deleted the 428_score_output branch Mar 26, 2020
angela97lin added a commit that referenced this pull request Apr 13, 2020
* Objectives API: Create new binary / multiclass pipeline classes and remove objectives from pipeline classes (#405)

* Objectives API: Remove ROC and confusion matrix as objectives (#422)

* Change `score` output to return one dictionary (#429)

* Create binary and multiclass objective classes  (#504)

* Update dependencies  (#412)

* Hide features with zero importance in plot by default (#413)

* Update dependencies check: package whitelist (#417)

* Add fixes necessary for docs to build for improved objectives project (#605)

* Remove calculating plot metrics from AutoML  (#615)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants