-
Notifications
You must be signed in to change notification settings - Fork 91
Extended time series regularizer to support multiseries #4303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4303 +/- ##
=======================================
+ Coverage 99.7% 99.7% +0.1%
=======================================
Files 357 357
Lines 39694 39739 +45
=======================================
+ Hits 39574 39619 +45
Misses 120 120
☔ View full report in Codecov by Sentry. |
evalml/pipelines/components/transformers/preprocessing/time_series_regularizer.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're going to need more testing, but the impl itself is solid!
evalml/pipelines/components/transformers/preprocessing/time_series_regularizer.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick refactor but otherwise LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small comments, but nothing blocking. The tests are much cleaner now, thank you!
Pull Request Description
Extended time series regularizer to support multiseries
Closes #4304
Example of what this does
Let's say you have an unstacked X:
Where "2018-01-11", "2018-01-12" and "2018-01-16" are missing.
And you have an unstacked y:

Which is missing the values that correspond to the missing dates from X_unstacked (values jumps from 49 -> 60 and 74 -> 80).
If you call TimeSeriesRegularizer on X and y:

y will now regularize into:
Works also for duplicate datetimes, extra datetimes, and misaligned datetimes.
After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rst
to include this pull request by adding :pr:123
.