Skip to content

Fixed multiseries prediction interval labels#4377

Merged
christopherbunn merged 5 commits intomainfrom
fix_stl_pred_intervals
Jan 25, 2024
Merged

Fixed multiseries prediction interval labels#4377
christopherbunn merged 5 commits intomainfrom
fix_stl_pred_intervals

Conversation

@christopherbunn
Copy link
Contributor

@christopherbunn christopherbunn commented Jan 9, 2024

Resolves #4378

@christopherbunn christopherbunn changed the title Fix Multiseries Prediction Interval Labels Fix multiseries prediction interval labels Jan 9, 2024
@codecov
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8349680) 99.7% compared to head (b2145fa) 99.7%.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #4377     +/-   ##
=======================================
+ Coverage   99.7%   99.7%   +0.1%     
=======================================
  Files        357     357             
  Lines      39922   39928      +6     
=======================================
+ Hits       39796   39802      +6     
  Misses       126     126             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@christopherbunn christopherbunn changed the title Fix multiseries prediction interval labels Fixed multiseries prediction interval labels Jan 9, 2024
@christopherbunn christopherbunn marked this pull request as ready for review January 9, 2024 20:21
mock_transform_return_value = (
mock_X,
pd.DataFrame(np.random.rand(13, 5)),
mock_y,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

anyway we can add coverage here?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe here?

Copy link
Collaborator

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherbunn christopherbunn enabled auto-merge (squash) January 25, 2024 18:47
@christopherbunn christopherbunn merged commit c7843cd into main Jan 25, 2024
@christopherbunn christopherbunn deleted the fix_stl_pred_intervals branch January 25, 2024 19:11
@MichaelFu512 MichaelFu512 mentioned this pull request Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multiseries prediction interval labels includes target name twice

3 participants