Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for python 3.5 #438

Merged
merged 2 commits into from
Mar 3, 2020
Merged

Drop support for python 3.5 #438

merged 2 commits into from
Mar 3, 2020

Conversation

angela97lin
Copy link
Contributor

@angela97lin angela97lin commented Mar 3, 2020

Closes #435, dropping support for python 3.5.

Edit: do we also want to tackle removing any 3.5 specific things? (ex: OrderedDicts)

@codecov
Copy link

codecov bot commented Mar 3, 2020

Codecov Report

Merging #438 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #438   +/-   ##
=======================================
  Coverage   97.47%   97.47%           
=======================================
  Files         105      105           
  Lines        3290     3290           
=======================================
  Hits         3207     3207           
  Misses         83       83

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c06c73...01d8275. Read the comment docs.

Copy link
Contributor

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


**Breaking Changes**

* Python 3.5 will not be actively supported.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@dsherry dsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweeeet

@dsherry
Copy link
Contributor

dsherry commented Mar 3, 2020

@angela97lin RE your comment on 3.5-specific things: I see that 3.6 made dict sorting ordered by insertion by default. So I'm fine either way, as long as our test coverage ensures this to be true. Maybe a good separate PR.

@angela97lin
Copy link
Contributor Author

@dsherry Seems like it wouldn't hurt to keep in the OrderedDicts for now, so I won't change it quite yet (that way, py 3.5 users won't get different results even if we are not explicitly supporting 3.5 anymore)!

@angela97lin angela97lin merged commit b0d65a4 into master Mar 3, 2020
@angela97lin angela97lin deleted the 435_drop_py35 branch March 3, 2020 19:34
@angela97lin angela97lin mentioned this pull request Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop support for python 3.5
3 participants