Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #438 +/- ##
=======================================
Coverage 97.47% 97.47%
=======================================
Files 105 105
Lines 3290 3290
=======================================
Hits 3207 3207
Misses 83 83Continue to review full report at Codecov.
|
dsherry
reviewed
Mar 3, 2020
|
|
||
| **Breaking Changes** | ||
|
|
||
| * Python 3.5 will not be actively supported. |
Contributor
|
@angela97lin RE your comment on 3.5-specific things: I see that 3.6 made dict sorting ordered by insertion by default. So I'm fine either way, as long as our test coverage ensures this to be true. Maybe a good separate PR. |
Contributor
Author
|
@dsherry Seems like it wouldn't hurt to keep in the OrderedDicts for now, so I won't change it quite yet (that way, py 3.5 users won't get different results even if we are not explicitly supporting 3.5 anymore)! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #435, dropping support for python 3.5.
Edit: do we also want to tackle removing any 3.5 specific things? (ex: OrderedDicts)