Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused apply.py file #449

Merged
merged 4 commits into from Mar 6, 2020
Merged

Remove unused apply.py file #449

merged 4 commits into from Mar 6, 2020

Conversation

angela97lin
Copy link
Contributor

@angela97lin angela97lin commented Mar 5, 2020

Closes #448.

@codecov
Copy link

codecov bot commented Mar 5, 2020

Codecov Report

Merging #449 into master will increase coverage by 0.71%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #449      +/-   ##
==========================================
+ Coverage   97.47%   98.19%   +0.71%     
==========================================
  Files         105      104       -1     
  Lines        3292     3260      -32     
==========================================
- Hits         3209     3201       -8     
+ Misses         83       59      -24

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c40a5d2...de74361. Read the comment docs.

Copy link
Contributor

@jeremyliweishih jeremyliweishih left a comment

🍶

dsherry
dsherry approved these changes Mar 6, 2020
Copy link
Collaborator

@dsherry dsherry left a comment

👍 lol awesome! So that was all dead code? I wonder if our code coverage report can show us if there's any other stuff like that.

@dsherry
Copy link
Collaborator

dsherry commented Mar 6, 2020

Also thanks to @jeremyliweishih today I learned there's a sake emoji 😂

@angela97lin
Copy link
Contributor Author

angela97lin commented Mar 6, 2020

@dsherry Yup, seemed like it was code from the very beginnings of evalml 😆

If you go to https://codecov.io/gh/FeatureLabs/evalml, you can see the sunburst of overall code coverage--this file is red because there is none. Not sure if there's a better visualization but that's something! :D

@angela97lin angela97lin merged commit fb2ca4f into master Mar 6, 2020
2 checks passed
@dsherry
Copy link
Collaborator

dsherry commented Mar 6, 2020

@angela97lin ooh cool, thanks!

@angela97lin angela97lin mentioned this pull request Mar 9, 2020
@angela97lin angela97lin deleted the 448_cleanup_apply branch Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup unused apply.py file
3 participants