Adding Random State #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into random_state
kmax12
suggested changes
Sep 4, 2019
evalml/tests/test_pipelines.py
Outdated
| clf_2.fit(X, y) | ||
|
|
||
| assert clf_1.score(X, y) == clf.score(X, y) | ||
| assert clf.score(X, y) != clf_2.score(X, y) |
There was a problem hiding this comment.
i think this might not be a good test since technically we cannot guarantee that the two clfs will perform different just because they have random seeds
kmax12
approved these changes
Sep 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made sure random state was set in models, pipelines, and wherever randomness occurs.
Fixes #11.