Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Random State #45

Merged
merged 13 commits into from Sep 4, 2019
Merged

Adding Random State #45

merged 13 commits into from Sep 4, 2019

Conversation

jeremyliweishih
Copy link
Contributor

@jeremyliweishih jeremyliweishih commented Sep 3, 2019

Made sure random state was set in models, pipelines, and wherever randomness occurs.

Fixes #11.

  • Auto(*)
  • Pipelines
  • Tuners (SkOpt)
  • Utils (split_data())

@jeremyliweishih jeremyliweishih requested a review from kmax12 Sep 3, 2019
Copy link
Contributor

@kmax12 kmax12 left a comment

one comment. otherwise looks good

clf_2.fit(X, y)

assert clf_1.score(X, y) == clf.score(X, y)
assert clf.score(X, y) != clf_2.score(X, y)
Copy link
Contributor

@kmax12 kmax12 Sep 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this might not be a good test since technically we cannot guarantee that the two clfs will perform different just because they have random seeds

kmax12
kmax12 approved these changes Sep 4, 2019
Copy link
Contributor

@kmax12 kmax12 left a comment

LGTM. Go ahead and merge!

@jeremyliweishih jeremyliweishih merged commit 101a698 into master Sep 4, 2019
@dsherry dsherry deleted the random_state branch May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make sure random state is set everywhere
2 participants