-
Notifications
You must be signed in to change notification settings - Fork 89
Remove unused dependencies #451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #451 +/- ##
=======================================
Coverage 98.19% 98.19%
=======================================
Files 104 104
Lines 3260 3260
=======================================
Hits 3201 3201
Misses 59 59 Continue to review full report at Codecov.
|
Ah yeah, I think we removed the need for boto3 and boto-core when we moved our dataset offline, nice! :D |
Oooh, I found a hole in our checkin test coverage: we always install
The solution is to a) keep |
We list boto3 and boto-core as deps but don't use them in our repo.
s3fs is needed for the docs, but not by our code.
And ipywidgets appears to be needed to run our unit tests and build our docs, but it's not referenced anywhere in our code.
Related to #339