Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup for Auto-Assign Github App #477

Merged
merged 2 commits into from Apr 8, 2020
Merged

Setup for Auto-Assign Github App #477

merged 2 commits into from Apr 8, 2020

Conversation

christopherbunn
Copy link
Contributor

@christopherbunn christopherbunn commented Mar 10, 2020

Closes #469

@christopherbunn
Copy link
Contributor Author

christopherbunn commented Mar 10, 2020

@dsherry I think the configuration file is in place for this app. All that needs to be done is for @kmax12 to install it to the EvalML repo here: https://github.com/apps/auto-assign

@codecov
Copy link

codecov bot commented Mar 10, 2020

Codecov Report

Merging #477 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #477   +/-   ##
=======================================
  Coverage   98.87%   98.87%           
=======================================
  Files         118      118           
  Lines        4439     4439           
=======================================
  Hits         4389     4389           
  Misses         50       50           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7168311...6a4e241. Read the comment docs.

@kmax12
Copy link
Contributor

kmax12 commented Mar 10, 2020

i believe i just installed it. lmk if it works

@kmax12
Copy link
Contributor

kmax12 commented Mar 10, 2020

closing and testing opening a new PR to see if it works now

@kmax12 kmax12 closed this Mar 10, 2020
@kmax12 kmax12 reopened this Mar 10, 2020
@kmax12
Copy link
Contributor

kmax12 commented Mar 10, 2020

opening a new PR didn't work. if we don't like the app approach, we can also look into do this as a github action: https://github.com/marketplace/actions/auto-assign-action

Copy link
Collaborator

@dsherry dsherry left a comment

The change looks good to me, but keep me posted on whether this does the job

Copy link
Collaborator

@dsherry dsherry left a comment

@christopherbunn let's merge this! If it doesn't work, we can back it out.

@dsherry
Copy link
Collaborator

dsherry commented Apr 8, 2020

I just rebased this on master. If tests are green I plan to merge!

@dsherry dsherry merged commit 7b6c020 into master Apr 8, 2020
2 checks passed
@dsherry
Copy link
Collaborator

dsherry commented Apr 8, 2020

It worked!!!!

I put up a test PR #597 and after a minute or two I saw this happen:

Screen Shot 2020-04-08 at 1 21 51 PM

Thank you @christopherbunn !

@dsherry dsherry deleted the 469_auto_pr_author branch Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically set PR assignee to PR author
3 participants