This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pretty cool! Maybe related to @rwedge's comment but if we have this action, do we still need this in our circleCI workflow? :o That is, do we still need the CircleCI "check_dependencies_updated_linux" test?
Pretty cool! Maybe related to Roy's comment but if we have this action, do we still need this in our circleCI workflow? :o That is, do we still need the CircleCI "check_dependencies_updated_linux" test?
@angela97lin If the purpose of the "check_dependencies_updated_linux" test is to inform us that an error is is potentially caused by a dependency the "check_dependencies_updated_linux" test is still useful IMO.
So the update to our workflow: We see that the check check_dependencies_updated_linux fails, we could wait until the next day where a PR is automatically generated or manually do it ourselves that day? If that's so, is it true to say that this primarily to cover us for updates that happen at night / while we're away?
@angela97lin if only the check_dependencies_updated_linux check fails we could do either but it shouldn't stop develop as its only showing that dependencies updated (but the updated dependencies didn't cause any problems). We can just move check_dependencies_updated_linux into a non-required check. This is mainly just to save the hassle of manually putting up a PR.
It would be interesting if a PR could be automatically created when the check_dependencies_updated_linux test fails as well, but there would need to be a strategy to avoid multiple automated PRs proposing the same changes
@angela97lin Theres no real support for manually running actions but I know a hacky way to do it (you set the trigger to watch and click the star when you need it but this won't be a good idea once we open source). I can add that in after this PR. I can also just make it run every couple hours (or as much as we want really).
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.