Automate latest dependency PR #482

jeremyliweishih · 2020-03-11T15:31:34Z

Fixes #467.

This works through a github action on a cron schedule for everyday at 8:30 AM. I forked the create-pull-request github action (now under Featurelabs/create-pull-request) created by Peter Evans so we can review and keep the action static for security purposes.

Example of PR (changes not shown here): #480

The action works by checking if there is a diff between the base branch (when merged the base branch will be master) and the temp branch in the action runner. If there is a PR will be created and won't if not. More info here.

…67_dependency_action

codecov · 2020-03-11T15:43:12Z

Codecov Report

Merging #482 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #482   +/-   ##
=======================================
  Coverage   98.42%   98.42%           
=======================================
  Files         104      104           
  Lines        3427     3427           
=======================================
  Hits         3373     3373           
  Misses         54       54

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14b48cc...147b06c. Read the comment docs.

rwedge · 2020-03-11T18:20:37Z

.github/workflows/dependency_check.yml

+        id: vars
+        run: |
+          make installdeps-test
+          export whitelist="pandas|numpy|scikit|xgboost|catboost|category-encoders|cloudpickle|dask|distributed|pyzmq|statsmodels"


Some of this is repeated in the circleci workflow, yes? Maybe there should be a make action that generates the dependency text file that both the action and the workflow use.

Yes the circleci workflow uses the same file to check for diffs whereas this github action generates the file! Does that make sense?

I think in both cases a file is generated (albeit in different locations). We should avoid duplicating that code so it is easier to update the whitelist

Got it! I'll add it in.

angela97lin · 2020-03-11T18:41:01Z

Pretty cool! Maybe related to @rwedge's comment but if we have this action, do we still need this in our circleCI workflow? :o That is, do we still need the CircleCI "check_dependencies_updated_linux" test?

jeremyliweishih · 2020-03-11T18:44:30Z

Pretty cool! Maybe related to Roy's comment but if we have this action, do we still need this in our circleCI workflow? :o That is, do we still need the CircleCI "check_dependencies_updated_linux" test?

@angela97lin If the purpose of the "check_dependencies_updated_linux" test is to inform us that an error is is potentially caused by a dependency the "check_dependencies_updated_linux" test is still useful IMO.

rwedge · 2020-03-11T18:49:15Z

@angela97lin also since this check would only run once a day it could miss dependencies updated since the last time the check ran

angela97lin · 2020-03-11T18:58:25Z

@jeremyliweishih @rwedge Thanks!

So the update to our workflow: We see that the check check_dependencies_updated_linux fails, we could wait until the next day where a PR is automatically generated or manually do it ourselves that day? If that's so, is it true to say that this primarily to cover us for updates that happen at night / while we're away?

jeff-hernandez · 2020-03-11T19:05:46Z

.github/workflows/dependency_check.yml

+      - name: Create Pull Request
+        uses: Featurelabs/create-pull-request@v2
+        with:
+          token: ${{ secrets.GITHUB_TOKEN }}
+          commit-message: Update latest dependencies
+          title: Automated Latest Dependency Updates
+          body: This is an auto-generated PR with dependency updates.
+          branch: dep-update
+          base: master
+          reviewers: jeremyliweishih, angela97lin, dsherry


Does this step need to be conditional? What happens if there are no dependency updates?

create-pull-request handles that case by not doing anything.

jeremyliweishih · 2020-03-11T19:09:38Z

@angela97lin if only the check_dependencies_updated_linux check fails we could do either but it shouldn't stop develop as its only showing that dependencies updated (but the updated dependencies didn't cause any problems). We can just move check_dependencies_updated_linux into a non-required check. This is mainly just to save the hassle of manually putting up a PR.

rwedge · 2020-03-11T19:10:55Z

It would be interesting if a PR could be automatically created when the check_dependencies_updated_linux test fails as well, but there would need to be a strategy to avoid multiple automated PRs proposing the same changes

angela97lin · 2020-03-11T19:14:54Z

Gotcha! Hmm, is there a way to just run this action when a new PR is put up instead? Since that's usually when we'd notice this check fail and have to manually put up a PR 🤔

jeremyliweishih · 2020-03-11T19:16:27Z

@angela97lin Theres no real support for manually running actions but I know a hacky way to do it (you set the trigger to watch and click the star when you need it but this won't be a good idea once we open source). I can add that in after this PR. I can also just make it run every couple hours (or as much as we want really).

rwedge · 2020-03-11T22:00:04Z

.github/workflows/dependency_check.yml

+name: Update Dependencies
+on:
+  schedule:
+      - cron: '30 8 * * *'


Do you want this to be 8:30 am eastern?

yes ideally! Let me check how timezone works 😄

good catch its on UTC @rwedge

rwedge

I think the code looks good

dsherry · 2020-03-13T15:58:04Z

Makefile

+
+.PHONY: dependenciesfile
+dependenciesfile:
+		$(eval whitelist='pandas|numpy|scikit|xgboost|catboost|category-encoders|cloudpickle|dask|distributed|pyzmq|statsmodels')


Why use eval? Hmm was my use of export inappropriate?

I always forget how to set local variables in bash 😂

If this is in fact bash... hmm, how do our build scripts handle cross-platform support?

It makes perfect sense for the .config file but there is some make vs. bash syntax (and how they interact) that I don't fully understand yet that prompted the use of this weird syntax.

dsherry · 2020-03-13T16:00:25Z

.github/workflows/dependency_check.yml

+          body: This is an auto-generated PR with dependency updates.
+          branch: dep-update
+          base: master
+          reviewers: jeremyliweishih, angela97lin, dsherry


This is great. I wonder if there's a way to just say evalml-team or something. But no need to solve that now

Yes that would work! I need to make a new team though - currently we have Feature Labs and Team Jeff 😄

Ooh then we should do that! How do we do that?

Doesn't need to happen in this PR if you don't wanna wait

dsherry

Great stuff! So cool to have this :)

dsherry · 2020-03-13T16:02:49Z

.github/workflows/dependency_check.yml

+name: Update Dependencies
+on:
+  schedule:
+      - cron: '30 12 * * *'


Cool, I see this resolves to 12:30pm UTC, i.e. 8:30am EST. Just a note that this will shift an hour earlier from Nov-March with DST, lol!

…s/evalml into 467_dependency_action

jeremyliweishih added 18 commits March 11, 2020 09:51

Add first trial of workflow

ad96ccc

Add cron time

a9b7059

Merge branch 'master' of https://github.com/FeatureLabs/evalml into 4…

4521bbc

…67_dependency_action

Change to 5 min for testing

152b818

Add to star testing

3257f68

Syntax

75f6c6f

Test with push

5618427

Use 3.8.2

57a6621

Add install pip

1993b7d

Remove virtualenv

69064f2

Test with diff.txt

6af01d9

Add directory

38d246e

Force dif

e1b597f

Show latest_depedency

6e00c08

Run everyday at 8:30

52f5adc

Use forked action

91074fd

Back to push to test

6b533cc

Back to cron

f8aac6c

jeremyliweishih self-assigned this Mar 11, 2020

jeremyliweishih added 2 commits March 11, 2020 11:33

Make base consistent

63aad34

CL

dfadc80

jeremyliweishih requested review from jeff-hernandez, angela97lin and dsherry March 11, 2020 15:37

Add reviewers

9f46572

rwedge reviewed Mar 11, 2020

View reviewed changes

Move whitelist to make

4efeed7

jeff-hernandez reviewed Mar 11, 2020

View reviewed changes

Fix eval

36e8097

jeremyliweishih requested a review from rwedge March 11, 2020 20:05

rwedge reviewed Mar 11, 2020

View reviewed changes

Use correct 8:30AM

b58bf3f

rwedge approved these changes Mar 12, 2020

View reviewed changes

Merge branch 'master' into 467_dependency_action

78bc732

dsherry reviewed Mar 13, 2020

View reviewed changes

Merge branch 'master' into 467_dependency_action

659b9ad

dsherry approved these changes Mar 13, 2020

View reviewed changes

jeremyliweishih added 4 commits March 13, 2020 12:15

Change to team-reviewers

5e2787a

Merge branch '467_dependency_action' of https://github.com/FeatureLab…

417e070

…s/evalml into 467_dependency_action

Use proper syntax'

71d805d

Merge branch 'master' into 467_dependency_action

147b06c

jeremyliweishih merged commit 91c2b3a into master Mar 13, 2020

angela97lin mentioned this pull request Apr 1, 2020

Make release for v0.8.0 #565

Merged

dsherry deleted the 467_dependency_action branch October 29, 2020 23:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Automate latest dependency PR #482

Automate latest dependency PR #482

jeremyliweishih commented Mar 11, 2020 •

edited

Loading

codecov bot commented Mar 11, 2020 •

edited

Loading

rwedge Mar 11, 2020

jeremyliweishih Mar 11, 2020 •

edited

Loading

rwedge Mar 11, 2020 •

edited

Loading

jeremyliweishih Mar 11, 2020

angela97lin commented Mar 11, 2020 •

edited

Loading

jeremyliweishih commented Mar 11, 2020

rwedge commented Mar 11, 2020

angela97lin commented Mar 11, 2020

jeff-hernandez Mar 11, 2020

jeremyliweishih Mar 11, 2020

jeremyliweishih commented Mar 11, 2020

rwedge commented Mar 11, 2020

angela97lin commented Mar 11, 2020

jeremyliweishih commented Mar 11, 2020

rwedge Mar 11, 2020

jeremyliweishih Mar 12, 2020

jeremyliweishih Mar 12, 2020

rwedge left a comment

dsherry Mar 13, 2020

dsherry Mar 13, 2020

dsherry Mar 13, 2020

jeremyliweishih Mar 13, 2020

dsherry Mar 13, 2020

jeremyliweishih Mar 13, 2020

dsherry Mar 13, 2020

dsherry Mar 13, 2020

dsherry left a comment

dsherry Mar 13, 2020

Automate latest dependency PR #482

Automate latest dependency PR #482

Conversation

jeremyliweishih commented Mar 11, 2020 • edited Loading

codecov bot commented Mar 11, 2020 • edited Loading

Codecov Report

Choose a reason for hiding this comment

jeremyliweishih Mar 11, 2020 • edited Loading

Choose a reason for hiding this comment

rwedge Mar 11, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

angela97lin commented Mar 11, 2020 • edited Loading

jeremyliweishih commented Mar 11, 2020

rwedge commented Mar 11, 2020

angela97lin commented Mar 11, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jeremyliweishih commented Mar 11, 2020

rwedge commented Mar 11, 2020

angela97lin commented Mar 11, 2020

jeremyliweishih commented Mar 11, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rwedge left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dsherry left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jeremyliweishih commented Mar 11, 2020 •

edited

Loading

codecov bot commented Mar 11, 2020 •

edited

Loading

jeremyliweishih Mar 11, 2020 •

edited

Loading

rwedge Mar 11, 2020 •

edited

Loading

angela97lin commented Mar 11, 2020 •

edited

Loading