Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment asking not to delete dep-updates branch on merge #497

Merged
merged 5 commits into from Mar 16, 2020

Conversation

dsherry
Copy link
Collaborator

@dsherry dsherry commented Mar 16, 2020

@jeremyliweishih FYI

I think I got the syntax right but please check me! :)

@dsherry dsherry added enhancement An improvement to an existing feature. testing Issues related to testing. labels Mar 16, 2020
@dsherry
Copy link
Collaborator Author

dsherry commented Mar 16, 2020

I'm glad to see there's error checking in place for the yaml! https://github.com/FeatureLabs/evalml/pull/497/checks?check_run_id=511383068

Fixing

@codecov
Copy link

codecov bot commented Mar 16, 2020

Codecov Report

Merging #497 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #497   +/-   ##
=======================================
  Coverage   98.42%   98.42%           
=======================================
  Files         104      104           
  Lines        3427     3427           
=======================================
  Hits         3373     3373           
  Misses         54       54

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a857ecc...61f5edb. Read the comment docs.

Copy link
Contributor

@jeremyliweishih jeremyliweishih left a comment

LGTM 👕

@dsherry dsherry merged commit 67c2a52 into master Mar 16, 2020
2 checks passed
@dsherry dsherry deleted the ds_update_dep_comment branch Mar 16, 2020
@@ -22,7 +22,8 @@ jobs:
token: ${{ secrets.GITHUB_TOKEN }}
commit-message: Update latest dependencies
title: Automated Latest Dependency Updates
body: This is an auto-generated PR with dependency updates.
body: "This is an auto-generated PR with dependency updates.
Please do not delete the dep-update branch because it's needed by the auto-dependency bot."
Copy link
Collaborator Author

@dsherry dsherry Mar 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂oops I always had trouble with its vs it's

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement to an existing feature. testing Issues related to testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants