Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate parameters and describe in PipelineBase #501

Merged
merged 9 commits into from Mar 17, 2020

Conversation

jeremyliweishih
Copy link
Contributor

@jeremyliweishih jeremyliweishih commented Mar 16, 2020

fixes #362.

@@ -299,6 +289,20 @@ def graph(self, filepath=None):
"""
return make_pipeline_graph(self.component_graph, self.name, filepath=filepath)

@property
Copy link
Contributor Author

@jeremyliweishih jeremyliweishih Mar 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will change the behavior of PipelineBase.parameters from the parameters dictionary the user provides into the parameters of the initialized components. After #500 the two behaviors should be equivalent.

Copy link
Collaborator

@dsherry dsherry Mar 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@codecov
Copy link

codecov bot commented Mar 16, 2020

Codecov Report

Merging #501 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #501   +/-   ##
=======================================
  Coverage   98.43%   98.44%           
=======================================
  Files         105      105           
  Lines        3450     3469   +19     
=======================================
+ Hits         3396     3415   +19     
  Misses         54       54           
Impacted Files Coverage Δ
evalml/utils/logger.py 95.23% <ø> (ø)
evalml/pipelines/pipeline_base.py 97.63% <100.00%> (+0.01%) ⬆️
evalml/tests/pipeline_tests/test_pipelines.py 100.00% <100.00%> (ø)
evalml/tests/pipeline_tests/test_rf.py 100.00% <100.00%> (ø)
evalml/tests/pipeline_tests/test_rf_regression.py 100.00% <100.00%> (ø)
evalml/tests/pipeline_tests/test_xgboost.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c088b70...2cf8059. Read the comment docs.

@jeremyliweishih jeremyliweishih changed the title [WIP] Separate parameters and describe in PipelineBase Separate parameters and describe in PipelineBase Mar 16, 2020
@jeremyliweishih jeremyliweishih requested a review from dsherry Mar 16, 2020
evalml/pipelines/pipeline_base.py Outdated Show resolved Hide resolved
'Simple Imputer': {
'impute_strategy': 'median'
},
'Logistic Regression Classifier': {
'penalty': 'l2',
'C': 3.0,
'random_state': 1
Copy link
Collaborator

@dsherry dsherry Mar 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come this went away in this PR?

Copy link
Contributor Author

@jeremyliweishih jeremyliweishih Mar 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the parameters property is taken from the initialized components instead of the parameters dictionary parameters such as random_state don't show up anymore! When #500 gets fixed it should edit this test to add it back in.

@dsherry
Copy link
Collaborator

dsherry commented Mar 17, 2020

@jeremyliweishih do you have a separate issue for doing the same thing for ComponentBase? If not, it would be great to add that to this PR!

Copy link
Collaborator

@dsherry dsherry left a comment

I added a couple suggestions, but LGTM!

As mentioned, if we don't have a separate issue yet for doing the same thing for components, we should either file an issue or also do that in this PR.

@jeremyliweishih
Copy link
Contributor Author

jeremyliweishih commented Mar 17, 2020

@jeremyliweishih do you have a separate issue for doing the same thing for ComponentBase? If not, it would be great to add that to this PR!

@dsherry I filed #500 to track that!

@jeremyliweishih jeremyliweishih merged commit 6501d43 into master Mar 17, 2020
2 checks passed
@dsherry dsherry deleted the js_362_describe branch Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up PipelineBase.describe and ComponentBase.describe APIs
2 participants