Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor for model family #507

Merged
merged 29 commits into from Mar 19, 2020
Merged

Refactor for model family #507

merged 29 commits into from Mar 19, 2020

Conversation

jeremyliweishih
Copy link
Contributor

@jeremyliweishih jeremyliweishih commented Mar 18, 2020

Fixes #379.

@jeremyliweishih jeremyliweishih self-assigned this Mar 18, 2020
@codecov
Copy link

codecov bot commented Mar 18, 2020

Codecov Report

Merging #507 into master will decrease coverage by 0.02%.
The diff coverage is 98.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #507      +/-   ##
==========================================
- Coverage   98.46%   98.43%   -0.03%     
==========================================
  Files         105      105              
  Lines        3514     3518       +4     
==========================================
+ Hits         3460     3463       +3     
- Misses         54       55       +1     
Impacted Files Coverage Δ
evalml/automl/auto_classification_search.py 100.00% <ø> (ø)
evalml/automl/auto_regression_search.py 100.00% <ø> (ø)
evalml/pipelines/__init__.py 100.00% <ø> (ø)
evalml/pipelines/classification/catboost.py 100.00% <ø> (ø)
...ml/pipelines/classification/logistic_regression.py 100.00% <ø> (ø)
evalml/pipelines/classification/random_forest.py 100.00% <ø> (ø)
evalml/pipelines/classification/xgboost.py 100.00% <ø> (ø)
evalml/pipelines/regression/catboost.py 100.00% <ø> (ø)
evalml/pipelines/regression/linear_regression.py 100.00% <ø> (ø)
evalml/pipelines/regression/random_forest.py 100.00% <ø> (ø)
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac64cb2...da0e987. Read the comment docs.

@jeremyliweishih jeremyliweishih changed the title [WIP] Refactor for model family Refactor for model family Mar 18, 2020
@jeremyliweishih jeremyliweishih requested a review from dsherry Mar 18, 2020
evalml/model_family/model_family.py Outdated Show resolved Hide resolved
evalml/model_family/utils.py Outdated Show resolved Hide resolved
evalml/utils/gen_utils.py Outdated Show resolved Hide resolved
evalml/utils/gen_utils.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@dsherry dsherry left a comment

LGTM!

@jeremyliweishih jeremyliweishih merged commit 54a2a72 into master Mar 19, 2020
1 of 2 checks passed
@dsherry dsherry deleted the js_379_model_family branch Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add model_family to each component
3 participants