Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit the number of categories in one hot encoding #517

Merged
merged 33 commits into from Mar 30, 2020

Conversation

angela97lin
Copy link
Contributor

@angela97lin angela97lin commented Mar 23, 2020

Closes #472.

@codecov
Copy link

codecov bot commented Mar 26, 2020

Codecov Report

Merging #517 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #517   +/-   ##
=======================================
  Coverage   98.73%   98.73%           
=======================================
  Files         115      115           
  Lines        4205     4205           
=======================================
  Hits         4152     4152           
  Misses         53       53           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd2138f...cd2138f. Read the comment docs.

@angela97lin angela97lin changed the title [WIP] Limit the number of categories in one hot encoding Limit the number of categories in one hot encoding Mar 27, 2020
@angela97lin angela97lin requested review from kmax12 and dsherry Mar 27, 2020
@angela97lin angela97lin requested a review from kmax12 Mar 28, 2020
kmax12
kmax12 approved these changes Mar 28, 2020
Copy link
Contributor

@kmax12 kmax12 left a comment

just a couple comments. otherwise, looks good to merge

@angela97lin angela97lin requested a review from kmax12 Mar 30, 2020
kmax12
kmax12 approved these changes Mar 30, 2020
Copy link
Contributor

@kmax12 kmax12 left a comment

LGTM

@angela97lin angela97lin merged commit 4cfa276 into master Mar 30, 2020
2 checks passed
@angela97lin angela97lin deleted the 472_limit_one_hot_encoding branch Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Limit number of unique categories in one hot encoding
2 participants