Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move serialization to PipelineBase #526

Merged
merged 6 commits into from Mar 27, 2020
Merged

Conversation

jeremyliweishih
Copy link
Contributor

@jeremyliweishih jeremyliweishih commented Mar 26, 2020

Fixes #386.

@jeremyliweishih jeremyliweishih changed the title Move serialization to PipelineBase [WIP] Move serialization to PipelineBase Mar 26, 2020
@codecov
Copy link

codecov bot commented Mar 26, 2020

Codecov Report

Merging #526 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #526   +/-   ##
=======================================
  Coverage   98.69%   98.69%           
=======================================
  Files         113      113           
  Lines        3971     3972    +1     
=======================================
+ Hits         3919     3920    +1     
  Misses         52       52           
Impacted Files Coverage Δ
evalml/pipelines/__init__.py 100.00% <ø> (ø)
evalml/pipelines/utils.py 100.00% <ø> (ø)
evalml/__init__.py 100.00% <100.00%> (ø)
evalml/pipelines/pipeline_base.py 98.45% <100.00%> (+0.06%) ⬆️
evalml/tests/pipeline_tests/test_pipelines.py 99.58% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ced9b58...c6bd252. Read the comment docs.

@jeremyliweishih jeremyliweishih changed the title [WIP] Move serialization to PipelineBase Move serialization to PipelineBase Mar 26, 2020
@jeremyliweishih jeremyliweishih requested a review from dsherry Mar 26, 2020
@@ -147,7 +145,7 @@ def test_load_pickled_pipeline_with_custom_objective(X_y, pickled_pipeline_path,
objective = Precision()
pipeline = LogisticRegressionPipeline(objective=objective, parameters=lr_pipeline.parameters)
pipeline.fit(X, y)
assert load_pipeline(pickled_pipeline_path).score(X, y) == pipeline.score(X, y)
assert PipelineBase.load(pickled_pipeline_path).score(X, y) == pipeline.score(X, y)
Copy link
Collaborator

@dsherry dsherry Mar 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, this is great.

Copy link
Collaborator

@dsherry dsherry left a comment

Good idea!

@jeremyliweishih jeremyliweishih merged commit 3988eab into master Mar 27, 2020
2 checks passed
@dsherry dsherry deleted the js_386_serialize branch Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add machine-readable serialization for PipelineBase
2 participants