Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #535

Merged
merged 5 commits into from
Apr 7, 2020
Merged

Update README.md #535

merged 5 commits into from
Apr 7, 2020

Conversation

gsheni
Copy link
Contributor

@gsheni gsheni commented Mar 30, 2020

Pull Request Description

  • README.md had invalid documentation link

@gsheni
Update README.md
b8c1e20 
- README.md had invalid documentation link
@gsheni gsheni self-assigned this Mar 30, 2020
@codecov
Copy link

codecov bot commented Mar 30, 2020 •
edited
Loading

Codecov Report

Merging #535 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #535   +/-   ##
=======================================
  Coverage   98.87%   98.87%           
=======================================
  Files         118      118           
  Lines        4439     4439           
=======================================
  Hits         4389     4389           
  Misses         50       50

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a49ca16...bf87b12. Read the comment docs.

dsherry
dsherry approved these changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@dsherry dsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks like you just need to add a changelog entry and this is good to go.

@gsheni
Copy link
Contributor Author

gsheni commented Mar 30, 2020

Thanks! Looks like you just need to add a changelog entry and this is good to go.

Fixed. Ready to merge in.

@dsherry dsherry added the documentation Improvements or additions to documentation label Apr 4, 2020
@gsheni gsheni merged commit 1e6be7f into master Apr 7, 2020
@gsheni gsheni deleted the fix_readme_link branch April 7, 2020 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherry dsherry dsherry approved these changes

Assignees

@gsheni gsheni

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gsheni @dsherry