Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have build_docs job use python executor #547

Merged
merged 2 commits into from Mar 31, 2020
Merged

Conversation

dsherry
Copy link
Collaborator

@dsherry dsherry commented Mar 31, 2020

Closes #544

Theory is that doing this will consistently set env vars like OMP_NUM_THREADS

@codecov
Copy link

codecov bot commented Mar 31, 2020

Codecov Report

Merging #547 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #547   +/-   ##
=======================================
  Coverage   98.73%   98.73%           
=======================================
  Files         115      115           
  Lines        4205     4205           
=======================================
  Hits         4152     4152           
  Misses         53       53           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e2c7d4...74c1f05. Read the comment docs.

@@ -195,13 +195,16 @@ jobs:

build_docs:
working_directory: ~/evalml/
docker:
- image: circleci/python:3.8
Copy link
Collaborator Author

@dsherry dsherry Mar 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is part of the problem. Note that we configure OMP_NUM_THREADS in the executors section. As for why this problem would have started happening in the past week or so, that I don't know.

@dsherry dsherry requested a review from rwedge Mar 31, 2020
Copy link
Contributor

@jeremyliweishih jeremyliweishih left a comment

🚢

@dsherry dsherry merged commit 0c94ffd into master Mar 31, 2020
2 checks passed
@dsherry dsherry deleted the ds_544_set_num_threads branch Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timeout in build_docs job: xgboost hanging on circleci
2 participants