Have build_docs job use python executor #547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nv vars like OMP_NUM_THREADS are set
Codecov Report
@@ Coverage Diff @@
## master #547 +/- ##
=======================================
Coverage 98.73% 98.73%
=======================================
Files 115 115
Lines 4205 4205
=======================================
Hits 4152 4152
Misses 53 53 Continue to review full report at Codecov.
|
dsherry
commented
Mar 31, 2020
| @@ -195,13 +195,16 @@ jobs: | |||
|
|
|||
| build_docs: | |||
| working_directory: ~/evalml/ | |||
| docker: | |||
| - image: circleci/python:3.8 | |||
There was a problem hiding this comment.
I think this is part of the problem. Note that we configure OMP_NUM_THREADS in the executors section. As for why this problem would have started happening in the past week or so, that I don't know.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #544
Theory is that doing this will consistently set env vars like
OMP_NUM_THREADS