Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run windows unit tests on prs #557

Merged
merged 2 commits into from Apr 1, 2020
Merged

Conversation

dsherry
Copy link
Collaborator

@dsherry dsherry commented Apr 1, 2020

As mentioned in #532

@dsherry dsherry added the testing Issues related to testing. label Apr 1, 2020
@dsherry dsherry self-assigned this Apr 1, 2020
@codecov
Copy link

codecov bot commented Apr 1, 2020

Codecov Report

Merging #557 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #557   +/-   ##
=======================================
  Coverage   98.73%   98.73%           
=======================================
  Files         115      115           
  Lines        4205     4205           
=======================================
  Hits         4152     4152           
  Misses         53       53           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83dc3e2...f681f72. Read the comment docs.

@angela97lin
Copy link
Contributor

angela97lin commented Apr 1, 2020

Nice, definitely a fan of this 👍

@dsherry
Copy link
Collaborator Author

dsherry commented Apr 1, 2020

I see the windows tests took 18min to install xgboost on python 3.8. Will keep any eye on that. We should be able to keep the job time comparable to linux.

@dsherry dsherry force-pushed the ds_run_windows_unit_tests_on_prs branch from 0020f02 to f681f72 Compare Apr 1, 2020
@dsherry
Copy link
Collaborator Author

dsherry commented Apr 1, 2020

I see the python 3.8 windows tests consistently take ~18min to install xgboost via conda. That's unfortunate. I think we can improve that. I'll file an issue and try to fix asap.

@dsherry dsherry mentioned this pull request Apr 1, 2020
Copy link
Contributor

@angela97lin angela97lin left a comment

Nice, LGTM! 🚢

@dsherry dsherry merged commit 2e0288e into master Apr 1, 2020
2 checks passed
@dsherry dsherry deleted the ds_run_windows_unit_tests_on_prs branch Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Issues related to testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants