-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run windows unit tests on prs #557
Conversation
Codecov Report
@@ Coverage Diff @@
## master #557 +/- ##
=======================================
Coverage 98.73% 98.73%
=======================================
Files 115 115
Lines 4205 4205
=======================================
Hits 4152 4152
Misses 53 53 Continue to review full report at Codecov.
|
Nice, definitely a fan of this 👍 |
I see the windows tests took 18min to install xgboost on python 3.8. Will keep any eye on that. We should be able to keep the job time comparable to linux. |
0020f02
to
f681f72
Compare
I see the python 3.8 windows tests consistently take ~18min to install xgboost via conda. That's unfortunate. I think we can improve that. I'll file an issue and try to fix asap. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, LGTM! 🚢
As mentioned in #532