Run windows unit tests on prs #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #557 +/- ##
=======================================
Coverage 98.73% 98.73%
=======================================
Files 115 115
Lines 4205 4205
=======================================
Hits 4152 4152
Misses 53 53 Continue to review full report at Codecov.
|
|
Nice, definitely a fan of this 👍 |
|
I see the windows tests took 18min to install xgboost on python 3.8. Will keep any eye on that. We should be able to keep the job time comparable to linux. |
dsherry
force-pushed
the
ds_run_windows_unit_tests_on_prs
branch
from
0020f02 to
f681f72
Compare
|
I see the python 3.8 windows tests consistently take ~18min to install xgboost via conda. That's unfortunate. I think we can improve that. I'll file an issue and try to fix asap. |
Closed
jeremyliweishih
approved these changes
Apr 1, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #532