Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add verbose to load_fraud #560

Merged
merged 3 commits into from Apr 6, 2020
Merged

Add verbose to load_fraud #560

merged 3 commits into from Apr 6, 2020

Conversation

gsheni
Copy link
Member

@gsheni gsheni commented Apr 1, 2020

Pull Request Description

  • Sometimes a user may not want to print verbose output while doing load_fraud. This PR makes the change to allow for optionally changing that.

@codecov
Copy link

codecov bot commented Apr 1, 2020

Codecov Report

Merging #560 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #560   +/-   ##
=======================================
  Coverage   98.83%   98.83%           
=======================================
  Files         115      115           
  Lines        4297     4297           
=======================================
  Hits         4247     4247           
  Misses         50       50           
Impacted Files Coverage Δ
evalml/demos/fraud.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79a2358...f2f1e5c. Read the comment docs.

dsherry
dsherry approved these changes Apr 3, 2020
Copy link
Collaborator

@dsherry dsherry left a comment

Looks good to me! Thanks.

A thought: should we also update the demos (and therefore the load_data verbose option) to use our logger? evalml/utils/logger.py.

@gsheni
Copy link
Member Author

gsheni commented Apr 3, 2020

Looks good to me! Thanks.

A thought: should we also update the demos (and therefore the load_data verbose option) to use our logger? evalml/utils/logger.py.

Yah, we should. That way you can turn it to the level you want:

logging.basicConfig(level=your_level) #debug, info, warning, error, critical

@dsherry
Copy link
Collaborator

dsherry commented Apr 3, 2020

@gsheni cool, yeah. Our logger is very simple right now and doesn't support verbosity levels, but we plan to upgrade it to use the logging package as you mentioned: #460. At that point we could support all sorts of features including different verbosity. So while we can't do that logging level setting you mentioned yet, we'll be able to soon!

@dsherry dsherry added the enhancement An improvement to an existing feature. label Apr 4, 2020
@gsheni gsheni merged commit 17d854b into master Apr 6, 2020
2 checks passed
@gsheni gsheni deleted the add_verbose_load_demos branch Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement to an existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants