Clean up deps: remove 'plots' option from scikit-optimize, move category_encoders #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherry
changed the title
dsherry
added
enhancement
dsherry
force-pushed
the
ds_remove_graphviz_dep
branch
from
91f5444 to
24fb58c
Compare
Codecov Report
@@ Coverage Diff @@
## master #572 +/- ##
=======================================
Coverage 98.83% 98.83%
=======================================
Files 115 115
Lines 4297 4297
=======================================
Hits 4247 4247
Misses 50 50 Continue to review full report at Codecov.
|
dsherry
changed the title
| tqdm>=4.33.0 | ||
| colorama | ||
| category_encoders>=2.0.0 |
There was a problem hiding this comment.
Can you explain the reason why this was moved? We need it for our one hot encoder.
There was a problem hiding this comment.
Not anymore! @angela97lin wrote a custom implementation for #472 . We still use it in our tests though
There was a problem hiding this comment.
got it. Sounds good!
kmax12
changed the title
kmax12
approved these changes
Apr 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have core deps install scikit-optimize but not the 'plots' option (i.e. matplotlib). Actually I'm not sure we need matplotlib at all.