Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up deps: remove 'plots' option from scikit-optimize, move category_encoders #572

Merged
merged 3 commits into from Apr 2, 2020

Conversation

dsherry
Copy link
Collaborator

@dsherry dsherry commented Apr 2, 2020

Have core deps install scikit-optimize but not the 'plots' option (i.e. matplotlib). Actually I'm not sure we need matplotlib at all.

@dsherry dsherry changed the title [WIP] Remove 'plots' option from scikit-learn core deps [WIP] Clean up deps: remove 'plots' option from scikit-learn, move category_encoders Apr 2, 2020
@dsherry dsherry added enhancement An improvement to an existing feature. assisted modeling labels Apr 2, 2020
@dsherry dsherry force-pushed the ds_remove_graphviz_dep branch from 91f5444 to 24fb58c Compare Apr 2, 2020
@codecov
Copy link

codecov bot commented Apr 2, 2020

Codecov Report

Merging #572 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #572   +/-   ##
=======================================
  Coverage   98.83%   98.83%           
=======================================
  Files         115      115           
  Lines        4297     4297           
=======================================
  Hits         4247     4247           
  Misses         50       50           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 894f584...24fb58c. Read the comment docs.

@dsherry dsherry changed the title [WIP] Clean up deps: remove 'plots' option from scikit-learn, move category_encoders Clean up deps: remove 'plots' option from scikit-learn, move category_encoders Apr 2, 2020
@dsherry dsherry self-assigned this Apr 2, 2020
tqdm>=4.33.0
colorama
category_encoders>=2.0.0
Copy link
Contributor

@jeremyliweishih jeremyliweishih Apr 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain the reason why this was moved? We need it for our one hot encoder.

Copy link
Collaborator Author

@dsherry dsherry Apr 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not anymore! @angela97lin wrote a custom implementation for #472 . We still use it in our tests though

Copy link
Contributor

@jeremyliweishih jeremyliweishih Apr 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it. Sounds good!

Copy link
Contributor

@jeremyliweishih jeremyliweishih left a comment

LGTM

Copy link
Contributor

@angela97lin angela97lin left a comment

Niceeee, LGTM! 👍

@kmax12 kmax12 changed the title Clean up deps: remove 'plots' option from scikit-learn, move category_encoders Clean up deps: remove 'plots' option from scikit-optimize, move category_encoders Apr 2, 2020
kmax12
kmax12 approved these changes Apr 2, 2020
@dsherry dsherry merged commit ad4e0f1 into master Apr 2, 2020
2 checks passed
@dsherry dsherry deleted the ds_remove_graphviz_dep branch Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement to an existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants