Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix make installs and dependency checks #578

merged 7 commits into from Apr 3, 2020


Copy link

@jeremyliweishih jeremyliweishih commented Apr 2, 2020

fixes #576.

@jeremyliweishih jeremyliweishih self-assigned this Apr 2, 2020
Copy link

codecov bot commented Apr 2, 2020

Codecov Report

Merging #578 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #578   +/-   ##
  Coverage   98.83%   98.83%           
  Files         115      115           
  Lines        4297     4297           
  Hits         4247     4247           
  Misses         50       50           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad4e0f1...dda5459. Read the comment docs.

- run: |
virtualenv test_python -q
source test_python/bin/activate
make installdeps
pip install -r test-requirements.txt
make installdeps-dev
Copy link
Contributor Author

@jeremyliweishih jeremyliweishih Apr 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think -r at the top works in circleci

Copy link

@dsherry dsherry Apr 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what you mean--are you talking about pip install's -r? I think that will still work.

So isn't the make installdeps above redundant? Because pip install -r dev-requirements.txt will install requirements.txt? I suggest you delete that and just keep make installdeps-dev here

@jeremyliweishih jeremyliweishih requested a review from dsherry Apr 2, 2020
Makefile Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
.circleci/config.yml Show resolved Hide resolved
dsherry approved these changes Apr 2, 2020
Copy link

@dsherry dsherry left a comment

Left a couple suggestions but once those are resolved 🚢 ! Thank you.

@jeremyliweishih jeremyliweishih merged commit 79a2358 into master Apr 3, 2020
2 checks passed
@dsherry dsherry deleted the js_fix_action branch Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Have dependency check bot install same requirements as latest dependency checkin job
2 participants