-
Notifications
You must be signed in to change notification settings - Fork 89
Remove some docs warnings #593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #593 +/- ##
=======================================
Coverage 98.87% 98.87%
=======================================
Files 118 118
Lines 4439 4439
=======================================
Hits 4389 4389
Misses 50 50 Continue to review full report at Codecov.
|
This fixed the changelog warning, but I still see:
|
72026e2
to
61034f6
Compare
@@ -36,7 +38,6 @@ Changelog | |||
* Add code style and github issue guides :pr:`463` :pr:`512` | |||
* Updated API reference for to surface class variables for pipelines and components :pr:`537` | |||
* Fixed README documentation link :pr:`535` | |||
* Limit readthedocs formats to html and pdf, not epub :pr:`594` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops!
I still see:
is this PR also supposed to fix that? |
@jeremyliweishih nah I just wanted to get some fixes in. I wasn't able to figure out those warnings yet, will do in a separate PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks for fixing this up!
61034f6
to
99235aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay, this saves me from making the changes on my branches all the time lol, thanks for this!
Fixes warning about missing newline in changelog. Also remove duplicate entry in api docs.
Also fixing the changelog from my last PR #594 , accidentally put that in the 0.8.0 release notes 🤦♂️