Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit readthedocs formats to html and pdf, not epub/other #594

Merged
merged 3 commits into from
Apr 8, 2020

Conversation

dsherry
Copy link
Contributor

@dsherry dsherry commented Apr 8, 2020

Hopefully this will speed up the docs jobs on RTD.

@dsherry dsherry added documentation Improvements or additions to documentation enhancement An improvement to an existing feature. testing Issues related to testing. labels Apr 8, 2020
@dsherry dsherry self-assigned this Apr 8, 2020
@codecov
Copy link

codecov bot commented Apr 8, 2020

Codecov Report

Merging #594 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #594   +/-   ##
=======================================
  Coverage   98.87%   98.87%           
=======================================
  Files         118      118           
  Lines        4439     4439           
=======================================
  Hits         4389     4389           
  Misses         50       50           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e6be7f...991cd58. Read the comment docs.

@dsherry dsherry requested a review from angela97lin April 8, 2020 04:36
@dsherry
Copy link
Contributor Author

dsherry commented Apr 8, 2020

Yeah, looks like getting rid of epub shaved off a couple minutes
https://readthedocs.com/projects/feature-labs-inc-evalml/builds/313506/

@dsherry dsherry requested a review from jeremyliweishih April 8, 2020 15:21
@dsherry dsherry changed the title [WIP] Limit readthedocs formats to html and pdf, not epub/other Limit readthedocs formats to html and pdf, not epub/other Apr 8, 2020
Copy link
Collaborator

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@dsherry dsherry merged commit 7168311 into master Apr 8, 2020
@dsherry dsherry deleted the ds_limit_formats branch April 8, 2020 15:38
@dsherry dsherry mentioned this pull request Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement An improvement to an existing feature. testing Issues related to testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants